bug #61304 [PhpUnitBridge] Call Reflection*::setAccessible() only for PHP < 8.1 (W0rma)

nicolas-grekas · nicolas-grekas · commit 7e5543b13029 · 2025-08-04T15:41:37.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- [PhpUnitBridge] Call Reflection*::setAccessible() only for PHP < 8.1 | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT Follow-up of #61207 There are plans to deprecate `Reflection*::setAccessible()` in PHP 8.5: https://wiki.php.net/rfc/deprecations_php_8_5#extreflection_deprecations Thus, it might be beneficial to only call it if PHP < 8.1 is used. Commits ------- 9e89dd3 Reflection*::setAccessible() has no effect as of PHP 8.1
diff --git a/src/Symfony/Bridge/PhpUnit/CoverageListener.php b/src/Symfony/Bridge/PhpUnit/CoverageListener.php
@@ -86,7 +86,9 @@ public function startTest(Test $test): void
     private function addCoversForClassToAnnotationCache(Test $test, array $covers): void
     {
         $r = new \ReflectionProperty(TestUtil::class, 'annotationCache');
-        $r->setAccessible(true);
+        if (\PHP_VERSION_ID < 80100) {
+            $r->setAccessible(true);
+        }
 
         $cache = $r->getValue();
         $cache = array_replace_recursive($cache, [
@@ -103,7 +105,9 @@ private function addCoversForDocBlockInsideRegistry(Test $test, array $covers):
         $docBlock = Registry::getInstance()->forClassName(\get_class($test));
 
         $symbolAnnotations = new \ReflectionProperty($docBlock, 'symbolAnnotations');
-        $symbolAnnotations->setAccessible(true);
+        if (\PHP_VERSION_ID < 80100) {
+            $symbolAnnotations->setAccessible(true);
+        }
 
         // Exclude internal classes; PHPUnit 9.1+ is picky about tests covering, say, a \RuntimeException
         $covers = array_filter($covers, function (string $class) {
diff --git a/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Deprecation.php b/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Deprecation.php
@@ -437,7 +437,9 @@ public function toString()
     {
         $exception = new \Exception($this->message);
         $reflection = new \ReflectionProperty($exception, 'trace');
-        $reflection->setAccessible(true);
+        if (\PHP_VERSION_ID < 80100) {
+            $reflection->setAccessible(true);
+        }
         $reflection->setValue($exception, $this->trace);
 
         return ($this->originatesFromAnObject() ? 'deprecation triggered by '.$this->originatingClass().'::'.$this->originatingMethod().":\n" : '')
diff --git a/src/Symfony/Bridge/PhpUnit/Legacy/SymfonyTestsListenerTrait.php b/src/Symfony/Bridge/PhpUnit/Legacy/SymfonyTestsListenerTrait.php
@@ -357,7 +357,9 @@ private function willBeIsolated(TestCase $test): bool
         }
 
         $r = new \ReflectionProperty($test, 'runTestInSeparateProcess');
-        $r->setAccessible(true);
+        if (\PHP_VERSION_ID < 80100) {
+            $r->setAccessible(true);
+        }
 
         return $r->getValue($test) ?? false;
     }
diff --git a/src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/DeprecationTest.php b/src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/DeprecationTest.php
@@ -275,7 +275,9 @@ public static function setUpBeforeClass(): void
                     $loader = require $v.'/autoload.php';
                     $reflection = new \ReflectionClass($loader);
                     $prop = $reflection->getProperty('prefixDirsPsr4');
-                    $prop->setAccessible(true);
+                    if (\PHP_VERSION_ID < 80100) {
+                        $prop->setAccessible(true);
+                    }
                     $currentValue = $prop->getValue($loader);
                     self::$prefixDirsPsr4[] = [$prop, $loader, $currentValue];
                     $currentValue['Symfony\\Bridge\\PhpUnit\\'] = [realpath(__DIR__.'/../..')];

Original file line number	Diff line number	Diff line change
`@@ -357,7 +357,9 @@ private function willBeIsolated(TestCase $test): bool`
`357`	`357`	`}`
`358`	`358`
`359`	`359`	`$r = new \ReflectionProperty($test, 'runTestInSeparateProcess');`
`360`		`- $r->setAccessible(true);`
	`360`	`+ if (\PHP_VERSION_ID < 80100) {`
	`361`	`+ $r->setAccessible(true);`
	`362`	`+ }`
`361`	`363`
`362`	`364`	`return $r->getValue($test) ?? false;`
`363`	`365`	`}`