feature #61308 [Console] Adding more helpful error messages to the Questionhelper (mamazu)

fabpot · fabpot · commit d0118a9c97d4 · 2025-08-06T08:01:34.000+02:00
This PR was merged into the 7.4 branch. Discussion ---------- [Console] Adding more helpful error messages to the Questionhelper | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | - | License | MIT When trying to debug, having an error like this is not very helpful: ```text 1) Sylius\Bundle\GridBundle\Tests\Functional\Maker\MakeGridTest::it_can_create_grids_interactively Symfony\Component\Console\Exception\MissingInputException: Aborted. symfony/console/Helper/QuestionHelper.php:273 symfony/console/Helper/QuestionHelper.php:139 symfony/console/Helper/QuestionHelper.php:65 symfony/console/Helper/QuestionHelper.php:473 symfony/console/Helper/QuestionHelper.php:67 symfony/console/Style/SymfonyStyle.php:307 symfony/console/Style/SymfonyStyle.php:247 ``` When trying to debug where the error is actually coming from. More helpful would be: ```text 1) Sylius\Bundle\GridBundle\Tests\Functional\Maker\MakeGridTest::it_can_create_grids_interactively Symfony\Component\Console\Exception\MissingInputException: Aborted while asking: Entity class to create a grid for ``` Commits ------- 9aa3023 Adding more helpful error messages to the Questionhelper
diff --git a/src/Symfony/Component/Console/Helper/QuestionHelper.php b/src/Symfony/Component/Console/Helper/QuestionHelper.php
@@ -271,7 +271,7 @@ private function autocomplete(OutputInterface $output, Question $question, $inpu
             // as opposed to fgets(), fread() returns an empty string when the stream content is empty, not false.
             if (false === $c || ('' === $ret && '' === $c && null === $question->getDefault())) {
                 shell_exec('stty '.$sttyMode);
-                throw new MissingInputException('Aborted.');
+                throw new MissingInputException('Aborted while asking: '.$question->getQuestion());
             } elseif ("\177" === $c) { // Backspace Character
                 if (0 === $numMatches && 0 !== $i) {
                     --$i;
diff --git a/src/Symfony/Component/Console/Tests/Helper/QuestionHelperTest.php b/src/Symfony/Component/Console/Tests/Helper/QuestionHelperTest.php
@@ -740,7 +740,7 @@ public function testAskThrowsExceptionOnMissingInput()
     public function testAskThrowsExceptionOnMissingInputForChoiceQuestion()
     {
         $this->expectException(MissingInputException::class);
-        $this->expectExceptionMessage('Aborted.');
+        $this->expectExceptionMessage('Aborted while asking: Choice');
         (new QuestionHelper())->ask($this->createStreamableInputInterfaceMock($this->getInputStream('')), $this->createOutputInterface(), new ChoiceQuestion('Choice', ['a', 'b']));
     }
 

Original file line number	Diff line number	Diff line change
`@@ -740,7 +740,7 @@ public function testAskThrowsExceptionOnMissingInput()`
`740`	`740`	`public function testAskThrowsExceptionOnMissingInputForChoiceQuestion()`
`741`	`741`	`{`
`742`	`742`	`$this->expectException(MissingInputException::class);`
`743`		`- $this->expectExceptionMessage('Aborted.');`
	`743`	`+ $this->expectExceptionMessage('Aborted while asking: Choice');`
`744`	`744`	`(new QuestionHelper())->ask($this->createStreamableInputInterfaceMock($this->getInputStream('')), $this->createOutputInterface(), new ChoiceQuestion('Choice', ['a', 'b']));`
`745`	`745`	`}`
`746`	`746`