Merge branch '6.4' into 7.2

nicolas-grekas · nicolas-grekas · commit d0838f86e13a · 2025-07-30T19:31:35.000+02:00
* 6.4:
  [DependencyInjection] Escape parameters before resolving env placeholders
diff --git a/src/Symfony/Component/DependencyInjection/ContainerBuilder.php b/src/Symfony/Component/DependencyInjection/ContainerBuilder.php
@@ -824,7 +824,7 @@ public function compile(bool $resolveEnvPlaceholders = false): void
 
         if ($bag instanceof EnvPlaceholderParameterBag) {
             if ($resolveEnvPlaceholders) {
-                $this->parameterBag = new ParameterBag($this->resolveEnvPlaceholders($bag->all(), true));
+                $this->parameterBag = new ParameterBag($this->resolveEnvPlaceholders($this->escapeParameters($bag->all()), true));
             }
 
             $this->envPlaceholders = $bag->getEnvPlaceholders();
@@ -1777,4 +1777,18 @@ private function inVendors(string $path): bool
 
         return $this->pathsInVendor[$path] = false;
     }
+
+    private function escapeParameters(array $parameters): array
+    {
+        $params = [];
+        foreach ($parameters as $k => $v) {
+            $params[$k] = match (true) {
+                \is_array($v) => $this->escapeParameters($v),
+                \is_string($v) => str_replace('%', '%%', $v),
+                default => $v,
+            };
+        }
+
+        return $params;
+    }
 }
diff --git a/src/Symfony/Component/DependencyInjection/Tests/ContainerBuilderTest.php b/src/Symfony/Component/DependencyInjection/Tests/ContainerBuilderTest.php
@@ -892,6 +892,7 @@ public function testCompileWithResolveEnv()
         $container->setParameter('bar', '%% %env(DUMMY_ENV_VAR)% %env(DUMMY_SERVER_VAR)% %env(HTTP_DUMMY_VAR)%');
         $container->setParameter('foo', '%env(FOO)%');
         $container->setParameter('baz', '%foo%');
+        $container->setParameter('qux', '%%quux%%');
         $container->setParameter('env(HTTP_DUMMY_VAR)', '123');
         $container->register('teatime', 'stdClass')
             ->setProperty('foo', '%env(DUMMY_ENV_VAR)%')
diff --git a/src/Symfony/Component/Translation/Tests/TranslatorCacheTest.php b/src/Symfony/Component/Translation/Tests/TranslatorCacheTest.php
@@ -46,9 +46,9 @@ protected function deleteTmpDir()
                 continue;
             }
             if ($path->isDir()) {
-                rmdir($path->__toString());
+                @rmdir($path->__toString());
             } else {
-                unlink($path->__toString());
+                @unlink($path->__toString());
             }
         }
         rmdir($this->tmpDir);

Original file line number	Diff line number	Diff line change
`@@ -46,9 +46,9 @@ protected function deleteTmpDir()`
`46`	`46`	`continue;`
`47`	`47`	`}`
`48`	`48`	`if ($path->isDir()) {`
`49`		`- rmdir($path->__toString());`
	`49`	`+ @rmdir($path->__toString());`
`50`	`50`	`} else {`
`51`		`- unlink($path->__toString());`
	`51`	`+ @unlink($path->__toString());`
`52`	`52`	`}`
`53`	`53`	`}`
`54`	`54`	`rmdir($this->tmpDir);`