Skip to content

Bug fix: Conditional requestBody and parameters generation in serverless-openapi-documentation #53

@RaphaelSilva

Description

@RaphaelSilva

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch serverless-openapi-documentation@0.4.0 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/serverless-openapi-documentation/DefinitionGenerator.js b/node_modules/serverless-openapi-documentation/DefinitionGenerator.js
index 42d49bf..d77697d 100644
--- a/node_modules/serverless-openapi-documentation/DefinitionGenerator.js
+++ b/node_modules/serverless-openapi-documentation/DefinitionGenerator.js
@@ -111,12 +111,10 @@ class DefinitionGenerator {
         if (documentationConfig.deprecated) {
             operationObj.deprecated = true;
         }
-        if (operationObj.requestBody) {
+        if (documentationConfig.requestBody) {
             operationObj.requestBody = this.getRequestBodiesFromConfig(documentationConfig);
         }
-        if (operationObj.parameters) {
-            operationObj.parameters = this.getParametersFromConfig(documentationConfig);
-        }
+        operationObj.parameters = this.getParametersFromConfig(documentationConfig);
         operationObj.responses = this.getResponsesFromConfig(documentationConfig);
         return operationObj;
     }

This issue body was partially generated by patch-package.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions