Skip to content

Commit 0a240cc

Browse files
committed
Tests for invalid cases
1 parent 3ffbaca commit 0a240cc

File tree

1 file changed

+30
-12
lines changed

1 file changed

+30
-12
lines changed

tests/minifier.js

Lines changed: 30 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,13 @@ QUnit.test('parsing non-trivial markup', async function(assert) {
6060
assert.equal(await minify(input), input);
6161

6262
input = '<$unicorn>';
63-
// assert.throws(async function() {
64-
// await minify(input);
65-
// }, 'Invalid tag name');
63+
try {
64+
await minify(input);
65+
}
66+
catch (err) {
67+
assert.throws(err, 'Invalid tag name');
68+
}
69+
6670
assert.equal(await minify(input, {
6771
continueOnParseError: true,
6872
}), input);
@@ -95,10 +99,15 @@ QUnit.test('parsing non-trivial markup', async function(assert) {
9599
// https://github.com/kangax/html-minifier/issues/507
96100
input = '<tag v-ref:vm_pv :imgs=" objpicsurl_ "></tag>';
97101
assert.equal(await minify(input), input);
102+
98103
input = '<tag v-ref:vm_pv :imgs=" objpicsurl_ " ss"123>';
99-
// assert.throws(function() {
100-
// minify(input);
101-
// }, 'invalid attribute name');
104+
try {
105+
await minify(input);
106+
}
107+
catch (err) {
108+
assert.throws(err, 'invalid attribute name');
109+
}
110+
102111
assert.equal(await minify(input, {
103112
continueOnParseError: true,
104113
}), input);
@@ -112,6 +121,7 @@ QUnit.test('parsing non-trivial markup', async function(assert) {
112121
' data-ng-pattern="vm.options.format"' +
113122
' data-options="vm.datepickerOptions">';
114123
assert.equal(await minify(input), input);
124+
115125
input = '<input class="form-control" type="text" style="" id="{{vm.formInputName}}" name="{{vm.formInputName}}"' +
116126
' <!--FIXME hardcoded placeholder - dates may not be used for service required fields yet. -->' +
117127
' placeholder="YYYY-MM-DD"' +
@@ -120,18 +130,26 @@ QUnit.test('parsing non-trivial markup', async function(assert) {
120130
' data-ng-model-options="{ debounce: 1000 }"' +
121131
' data-ng-pattern="vm.options.format"' +
122132
' data-options="vm.datepickerOptions">';
123-
// assert.throws(function() {
124-
// minify(input);
125-
// }, 'HTML comment inside tag');
133+
try {
134+
await minify(input);
135+
}
136+
catch (err) {
137+
assert.throws(err, 'HTML comment inside tag');
138+
}
139+
126140
assert.equal(await minify(input, {
127141
continueOnParseError: true,
128142
}), input);
129143

130144
// https://github.com/kangax/html-minifier/issues/974
131145
input = '<!–– Failing New York Times Comment -->';
132-
// assert.throws(function() {
133-
// minify(input);
134-
// }, 'invalid HTML comment');
146+
try {
147+
await minify(input);
148+
}
149+
catch (err) {
150+
assert.throws(err, 'invalid HTML comment');
151+
}
152+
135153
assert.equal(await minify(input, {
136154
continueOnParseError: true,
137155
}), input);

0 commit comments

Comments
 (0)