Fix crash for type attribute without value (#133)

KartikSoneji · sibiraj-s · web-flow · commit 8b5c3f7f39fd · 2022-11-22T10:15:53.000+05:30
Co-authored-by: Sibiraj &lt;20282546+sibiraj-s@users.noreply.github.com&gt;
diff --git a/src/htmlminifier.js b/src/htmlminifier.js
@@ -166,12 +166,12 @@ const keepScriptsMimetypes = new Set([
   'module'
 ]);
 
-function isScriptTypeAttribute(attrValue) {
+function isScriptTypeAttribute(attrValue = '') {
   attrValue = trimWhitespace(attrValue.split(/;/, 2)[0]).toLowerCase();
   return attrValue === '' || executableScriptsMimetypes.has(attrValue);
 }
 
-function keepScriptTypeAttribute(attrValue) {
+function keepScriptTypeAttribute(attrValue = '') {
   attrValue = trimWhitespace(attrValue.split(/;/, 2)[0]).toLowerCase();
   return keepScriptsMimetypes.has(attrValue);
 }
@@ -189,7 +189,7 @@ function isExecutableScript(tag, attrs) {
   return true;
 }
 
-function isStyleLinkTypeAttribute(attrValue) {
+function isStyleLinkTypeAttribute(attrValue = '') {
   attrValue = trimWhitespace(attrValue).toLowerCase();
   return attrValue === '' || attrValue === 'text/css';
 }
diff --git a/tests/minifier.spec.js b/tests/minifier.spec.js
@@ -1107,6 +1107,12 @@ test('removing javascript type attributes', async () => {
   output = '<script>alert(1)</script>';
   expect(await minify(input, { removeScriptTypeAttributes: true })).toBe(output);
 
+  // https://github.com/terser/html-minifier-terser/issues/132
+  input = '<script type>alert(1)</script>';
+  expect(await minify(input, { removeScriptTypeAttributes: false })).toBe(input);
+  output = '<script>alert(1)</script>';
+  expect(await minify(input, { removeScriptTypeAttributes: true })).toBe(output);
+
   input = '<script type="modules">alert(1)</script>';
   expect(await minify(input, { removeScriptTypeAttributes: false })).toBe(input);
   output = '<script type="modules">alert(1)</script>';
@@ -1138,6 +1144,12 @@ test('removing type="text/css" attributes', async () => {
   output = '<style>.foo { color: red }</style>';
   expect(await minify(input, { removeStyleLinkTypeAttributes: true })).toBe(output);
 
+  // https://github.com/terser/html-minifier-terser/issues/132
+  input = '<style type>.foo { color: red }</style>';
+  expect(await minify(input, { removeStyleLinkTypeAttributes: false })).toBe(input);
+  output = '<style>.foo { color: red }</style>';
+  expect(await minify(input, { removeStyleLinkTypeAttributes: true })).toBe(output);
+
   input = '<style type="text/css">.foo { color: red }</style>';
   expect(await minify(input, { removeStyleLinkTypeAttributes: false })).toBe(input);
   output = '<style>.foo { color: red }</style>';
@@ -1154,6 +1166,11 @@ test('removing type="text/css" attributes', async () => {
   output = '<link rel="stylesheet" href="http://example.com">';
   expect(await minify(input, { removeStyleLinkTypeAttributes: true })).toBe(output);
 
+  // https://github.com/terser/html-minifier-terser/issues/132
+  input = '<link rel="stylesheet" type href="http://example.com">';
+  output = '<link rel="stylesheet" href="http://example.com">';
+  expect(await minify(input, { removeStyleLinkTypeAttributes: true })).toBe(output);
+
   input = '<link rel="alternate" type="application/atom+xml" href="data.xml">';
   expect(await minify(input, { removeStyleLinkTypeAttributes: true })).toBe(input);
 });

Original file line number	Diff line number	Diff line change
`@@ -166,12 +166,12 @@ const keepScriptsMimetypes = new Set([`
`166`	`166`	`'module'`
`167`	`167`	`]);`
`168`	`168`
`169`		`-function isScriptTypeAttribute(attrValue) {`
	`169`	`+function isScriptTypeAttribute(attrValue = '') {`
`170`	`170`	`attrValue = trimWhitespace(attrValue.split(/;/, 2)[0]).toLowerCase();`
`171`	`171`	`return attrValue === '' \|\| executableScriptsMimetypes.has(attrValue);`
`172`	`172`	`}`
`173`	`173`
`174`		`-function keepScriptTypeAttribute(attrValue) {`
	`174`	`+function keepScriptTypeAttribute(attrValue = '') {`
`175`	`175`	`attrValue = trimWhitespace(attrValue.split(/;/, 2)[0]).toLowerCase();`
`176`	`176`	`return keepScriptsMimetypes.has(attrValue);`
`177`	`177`	`}`
`@@ -189,7 +189,7 @@ function isExecutableScript(tag, attrs) {`
`189`	`189`	`return true;`
`190`	`190`	`}`
`191`	`191`
`192`		`-function isStyleLinkTypeAttribute(attrValue) {`
	`192`	`+function isStyleLinkTypeAttribute(attrValue = '') {`
`193`	`193`	`attrValue = trimWhitespace(attrValue).toLowerCase();`
`194`	`194`	`return attrValue === '' \|\| attrValue === 'text/css';`
`195`	`195`	`}`