Skip to content

Add test demonstrating issue #6811 #6812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add test demonstrating issue #6811 #6812

wants to merge 1 commit into from

Conversation

sffc
Copy link
Member

@sffc sffc commented Aug 6, 2025

According to #6811, ICU4X should sort these strings such that 0xFFFE is less than 0x0001 and 0x0000, but it is not.

@gemini-code-assist Gemini Code Assist
Copy link

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

@sffc sffc mentioned this pull request Aug 6, 2025
Open
@hsivonen hsivonen mentioned this pull request Aug 7, 2025
Open
hsivonen
hsivonen approved these changes Aug 7, 2025
View reviewed changes
Copy link
Member

@hsivonen hsivonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this changeset so that @sffc can approve #6814 without having to self-approve this changeset, which is part of that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsivonen hsivonen hsivonen approved these changes

@echeran echeran Awaiting requested review from echeran echeran will be requested when the pull request is marked ready for review echeran is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sffc @hsivonen