Skip to content

fix(Combobox): avoid auto focusing input when autoFocus: false (default) #2036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: v2
Choose a base branch
from
Draft

fix(Combobox): avoid auto focusing input when autoFocus: false (default) #2036

wants to merge 1 commit into from

Conversation

kricsleo
Copy link
Collaborator

@kricsleo kricsleo commented Jul 9, 2025

resolves #2034

This is mainly a draft PR to demonstrate how it would affect users who rely on the implicit behavior. ❤️

Before:

Auto-focus the input when the Combobox is opened, ignoring the autoFocus prop on ComboboxInput.

After:

Only auto-focus the input when the Combobox is opened when the autoFocus:true prop is set on ComboboxInput.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 9, 2025

Open in StackBlitz

npm i https://pkg.pr.new/reka-ui@2036

commit: 50a6563

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Autofocus prop doesn't work when ComboboxInput is placed inside ComboboxContent
1 participant
@kricsleo