fix(Listbox): prevent autofocus to avoid breaking other focusable elements #2092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2056
Previously,
Listboxwould automatically focus the highlighted item. This could interfere with other autofocusable elements, e.g., https://stackblitz.com/edit/rwxsez1n?file=src%2FApp.vue (theautofocusinput wouldn't receive focus). This PR fixes this issue.However, this PR doesn't completely resolve the keyboard navigation issue as described in the issue above. This is caused by
scrollIntoViewbecause it alters the starting point of keyboard navigation (Tab) (it's not entirely clear whyscrollIntoViewhas this effect). We can't simply removescrollIntoView, though, as automatically scrolling to the highlighted item seems more important than the keyboard navigation starting point, unless more issues are reported.