Fix to logic to determine if ACM_CERTIFICATE_ARN should be used, or a new certificate should be created and binded. Should fix Issue #95 where CNAME cannot be binded due to certificate not being binded to CloudFront.

bs-thomas · web-flow · commit 04704818d1f7 · 2022-06-29T16:39:46.000+08:00
diff --git a/serverless.yml b/serverless.yml
@@ -67,17 +67,20 @@ resources:
           Aliases:
             Fn::If:
             - CustomDomain
-            - - '${self:custom.settings.environment.CUSTOM_DOMAIN, self:custom.empty}'
+            - - '${self:custom.settings.environment.CUSTOM_DOMAIN, ""}'
             - Ref: AWS::NoValue
           ViewerCertificate:
             Fn::If:
+            - ArnCertificate
+            - MinimumProtocolVersion: 'TLSv1'
+              SslSupportMethod: 'sni-only'
+              AcmCertificateArn: ${self:custom.settings.environment.ACM_CERTIFICATE_ARN,''}
+            - Fn::If:
               - CreateCertificate
-              - AcmCertificateArn: !If
-                - ArnCertificate
-                - self:custom.settings.environment.ACM_CERTIFICATE_ARN
-                - Ref: Certificate
+              - MinimumProtocolVersion: 'TLSv1'
                 SslSupportMethod: 'sni-only'
-                MinimumProtocolVersion: 'TLSv1'
+                AcmCertificateArn:
+                  Ref: Certificate
               - Ref: AWS::NoValue
     Certificate:
       Type: AWS::CertificateManager::Certificate
