Turbopack: remove a few clones (#82435)

mischnic · web-flow · commit e5326844c7b7 · 2025-08-07T22:03:47.000+02:00
Showed up in an ast-grep search for `&amp;$$$.clone()`
diff --git a/crates/napi/src/react_compiler.rs b/crates/napi/src/react_compiler.rs
@@ -23,7 +23,7 @@ impl Task for CheckTask {
         GLOBALS.set(&Default::default(), || {
             //
             let cm = Arc::new(SourceMap::default());
-            let Ok(fm) = cm.load_file(&self.filename.clone()) else {
+            let Ok(fm) = cm.load_file(&self.filename) else {
                 return Ok(false);
             };
             let mut errors = vec![];
diff --git a/turbopack/crates/turbopack-core/src/resolve/mod.rs b/turbopack/crates/turbopack-core/src/resolve/mod.rs
@@ -1392,7 +1392,7 @@ async fn find_package(
                     for name in names.iter() {
                         let fs_path = lookup_path.join(name)?;
                         if let Some(fs_path) = dir_exists(fs_path, &mut affecting_sources).await? {
-                            let fs_path = fs_path.join(&package_name.clone())?;
+                            let fs_path = fs_path.join(&package_name)?;
                             if let Some(fs_path) =
                                 dir_exists(fs_path.clone(), &mut affecting_sources).await?
                             {
@@ -1431,7 +1431,7 @@ async fn find_package(
                     if excluded_extensions.contains(extension) {
                         continue;
                     }
-                    let package_file = package_dir.append(&extension.clone())?;
+                    let package_file = package_dir.append(extension)?;
                     if let Some(package_file) = exists(package_file, &mut affecting_sources).await?
                     {
                         packages.push(FindPackageItem::PackageFile(package_file));
diff --git a/turbopack/crates/turbopack-core/src/resolve/pattern.rs b/turbopack/crates/turbopack-core/src/resolve/pattern.rs
@@ -1631,7 +1631,7 @@ pub async fn read_matches(
                                     prefix.pop();
                                 }
                                 if let Some(pos) = pat.match_position(&prefix) {
-                                    let fs_path = lookup_dir.join(&key.clone())?;
+                                    let fs_path = lookup_dir.join(key)?;
                                     if let LinkContent::Link { link_type, .. } =
                                         &*fs_path.read_link().await?
                                     {
@@ -1653,7 +1653,7 @@ pub async fn read_matches(
                                 }
                                 prefix.push('/');
                                 if let Some(pos) = pat.match_position(&prefix) {
-                                    let fs_path = lookup_dir.join(&key.clone())?;
+                                    let fs_path = lookup_dir.join(key)?;
                                     if let LinkContent::Link { link_type, .. } =
                                         &*fs_path.read_link().await?
                                         && link_type.contains(LinkType::DIRECTORY)
@@ -1665,7 +1665,7 @@ pub async fn read_matches(
                                     }
                                 }
                                 if let Some(pos) = pat.could_match_position(&prefix) {
-                                    let fs_path = lookup_dir.join(&key.clone())?;
+                                    let fs_path = lookup_dir.join(key)?;
                                     if let LinkContent::Link { link_type, .. } =
                                         &*fs_path.read_link().await?
                                         && link_type.contains(LinkType::DIRECTORY)
diff --git a/turbopack/crates/turbopack-node/src/render/node_api_source.rs b/turbopack/crates/turbopack-node/src/render/node_api_source.rs
@@ -127,7 +127,7 @@ impl GetContentSourceContent for NodeApiContentSource {
         Ok(ContentSourceContent::HttpProxy(render_proxy_operation(
             self.cwd.clone(),
             self.env,
-            self.server_root.join(&path.clone())?,
+            self.server_root.join(&path)?,
             ResolvedVc::upcast(entry.module),
             entry.runtime_entries,
             entry.chunking_context,
diff --git a/turbopack/crates/turbopack-tests/tests/execution.rs b/turbopack/crates/turbopack-tests/tests/execution.rs
@@ -291,8 +291,8 @@ async fn prepare_test(resource: RcStr) -> Result<Vc<PreparedTest>> {
         resource_path.display()
     ))?;
     let relative_path: RcStr = sys_to_unix(relative_path.to_str().unwrap()).into();
-    let path = root_fs.root().await?.join(&relative_path.clone())?;
-    let project_path = project_root.join(&relative_path.clone())?;
+    let path = root_fs.root().await?.join(&relative_path)?;
+    let project_path = project_root.join(&relative_path)?;
     let tests_path = project_fs
         .root()
         .await?

Original file line number	Diff line number	Diff line change
`@@ -1392,7 +1392,7 @@ async fn find_package(`
`1392`	`1392`	`for name in names.iter() {`
`1393`	`1393`	`let fs_path = lookup_path.join(name)?;`
`1394`	`1394`	`if let Some(fs_path) = dir_exists(fs_path, &mut affecting_sources).await? {`
`1395`		`- let fs_path = fs_path.join(&package_name.clone())?;`
	`1395`	`+ let fs_path = fs_path.join(&package_name)?;`
`1396`	`1396`	`if let Some(fs_path) =`
`1397`	`1397`	`dir_exists(fs_path.clone(), &mut affecting_sources).await?`
`1398`	`1398`	`{`
`@@ -1431,7 +1431,7 @@ async fn find_package(`
`1431`	`1431`	`if excluded_extensions.contains(extension) {`
`1432`	`1432`	`continue;`
`1433`	`1433`	`}`
`1434`		`- let package_file = package_dir.append(&extension.clone())?;`
	`1434`	`+ let package_file = package_dir.append(extension)?;`
`1435`	`1435`	`if let Some(package_file) = exists(package_file, &mut affecting_sources).await?`
`1436`	`1436`	`{`
`1437`	`1437`	`packages.push(FindPackageItem::PackageFile(package_file));`
Original file line number	Diff line number	Diff line change
`@@ -1631,7 +1631,7 @@ pub async fn read_matches(`
`1631`	`1631`	`prefix.pop();`
`1632`	`1632`	`}`
`1633`	`1633`	`if let Some(pos) = pat.match_position(&prefix) {`
`1634`		`- let fs_path = lookup_dir.join(&key.clone())?;`
	`1634`	`+ let fs_path = lookup_dir.join(key)?;`
`1635`	`1635`	`if let LinkContent::Link { link_type, .. } =`
`1636`	`1636`	`&*fs_path.read_link().await?`
`1637`	`1637`	`{`
`@@ -1653,7 +1653,7 @@ pub async fn read_matches(`
`1653`	`1653`	`}`
`1654`	`1654`	`prefix.push('/');`
`1655`	`1655`	`if let Some(pos) = pat.match_position(&prefix) {`
`1656`		`- let fs_path = lookup_dir.join(&key.clone())?;`
	`1656`	`+ let fs_path = lookup_dir.join(key)?;`
`1657`	`1657`	`if let LinkContent::Link { link_type, .. } =`
`1658`	`1658`	`&*fs_path.read_link().await?`
`1659`	`1659`	`&& link_type.contains(LinkType::DIRECTORY)`
`@@ -1665,7 +1665,7 @@ pub async fn read_matches(`
`1665`	`1665`	`}`
`1666`	`1666`	`}`
`1667`	`1667`	`if let Some(pos) = pat.could_match_position(&prefix) {`
`1668`		`- let fs_path = lookup_dir.join(&key.clone())?;`
	`1668`	`+ let fs_path = lookup_dir.join(key)?;`
`1669`	`1669`	`if let LinkContent::Link { link_type, .. } =`
`1670`	`1670`	`&*fs_path.read_link().await?`
`1671`	`1671`	`&& link_type.contains(LinkType::DIRECTORY)`