Skip to content

Commit d2c6c8a

Browse files
committed
move flaky test asset to not run in FF
1 parent 2749077 commit d2c6c8a

File tree

1 file changed

+27
-26
lines changed

1 file changed

+27
-26
lines changed

test/playback.test.js

Lines changed: 27 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -250,32 +250,6 @@ QUnit.test('Live DASH', function(assert) {
250250
player.play();
251251
});
252252

253-
QUnit.test('Multiperiod dash works and can end', function(assert) {
254-
const done = assert.async();
255-
256-
assert.expect(2);
257-
const player = this.player;
258-
259-
playFor(player, 2, function() {
260-
assert.ok(true, 'played for at least two seconds');
261-
assert.equal(player.error(), null, 'has no player errors');
262-
263-
player.one('ended', () => {
264-
assert.ok(true, 'triggered ended event');
265-
done();
266-
});
267-
268-
player.currentTime(player.duration() - 0.5);
269-
270-
done();
271-
});
272-
273-
player.src({
274-
src: 'https://media.axprod.net/TestVectors/v7-Clear/Manifest_MultiPeriod.mpd',
275-
type: 'application/dash+xml'
276-
});
277-
});
278-
279253
// These videos don't work on firefox consistenly. Seems like
280254
// firefox has lower performance or more aggressive throttling than chrome
281255
// which causes a variety of issues.
@@ -423,6 +397,33 @@ if (!videojs.browser.IS_FIREFOX) {
423397
});
424398
});
425399

400+
// Firefox 64 cannot retrieve the asset, reporting a CORS issue.
401+
QUnit.test('Multiperiod dash works and can end', function(assert) {
402+
const done = assert.async();
403+
404+
assert.expect(2);
405+
const player = this.player;
406+
407+
playFor(player, 2, function() {
408+
assert.ok(true, 'played for at least two seconds');
409+
assert.equal(player.error(), null, 'has no player errors');
410+
411+
player.one('ended', () => {
412+
assert.ok(true, 'triggered ended event');
413+
done();
414+
});
415+
416+
player.currentTime(player.duration() - 0.5);
417+
418+
done();
419+
});
420+
421+
player.src({
422+
src: 'https://media.axprod.net/TestVectors/v7-Clear/Manifest_MultiPeriod.mpd',
423+
type: 'application/dash+xml'
424+
});
425+
});
426+
426427
// TODO: why does this make the next test
427428
// throw an "The operation was aborted." on firefox
428429
QUnit.test('loops', function(assert) {

0 commit comments

Comments
 (0)