-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Open
Description
The Travis contains a WP_MULTISITE=1
variable for both the matrix environment variables and the include environment variables.
wp-bootstrap-navwalker/.travis.yml
Lines 15 to 17 in c856e94
env: | |
- WP_VERSION=latest WP_MULTISITE=0 PHPUNIT_VERSION="^5.7" | |
- WP_VERSION=latest WP_MULTISITE=1 PHPUNIT_VERSION="^5.7" |
wp-bootstrap-navwalker/.travis.yml
Lines 28 to 31 in c856e94
- php: 7.0 | |
dist: xenial | |
env: | |
- WP_VERSION=latest WP_MULTISITE=1 PHPUNIT_VERSION="^5.7" |
While the other variables,
WP_VERSION
and PHPUNIT_VERSION
, are used, I don't see that WP_MULTISITE
is used anywhere.wp-bootstrap-navwalker/.travis.yml
Lines 65 to 67 in c856e94
install: | |
- bin/install-wp-tests.sh wordpress_test root "" localhost "${WP_VERSION}" | |
- composer global require --dev "phpunit/phpunit=${PHPUNIT_VERSION}" |
Additionally, the test file does not include any multisite tests. I think that all unit test with WP_MULTISITE=1
are duplicates of their WP_MULTISITE=0
versions and should be removed as they increase Travis build times and unnecessarily use Travis resources.