Bug#35710383 mysql server 8.1.0 crashed at GetAccessPathsFromItem

Jan Wedvik · dahlerlend · commit 170ff58ddaa3 · 2023-12-08T08:40:54.000+01:00
This commit removes a redundant if-test to fix the above bug. For the
failing query, the optimizer short-circuits planning for a subquery in
a projection due to an impossible HAVING condition. This then
triggered the null pointer error.

Change-Id: Id36450f92c872eb520d583d2902dd8d9b7803843
diff --git a/sql/join_optimizer/explain_access_path.cc b/sql/join_optimizer/explain_access_path.cc
@@ -235,9 +235,8 @@ static bool GetAccessPathsFromItem(Item *item_arg, const char *source_text,
                    "Select #%d (subquery in %s; run only once)",
                    query_block->select_number, source_text);
         }
-        if (query_block->join->needs_finalize) {
-          subselect->unit->finalize(current_thd);
-        }
+
+        subselect->unit->finalize(current_thd);
         AccessPath *path;
         if (subselect->unit->root_access_path() != nullptr) {
           path = subselect->unit->root_access_path();
