Bug#35115601 InnoDB - Page [...] still fixed or dirty crash during

ram1048 · ram1048 · commit a5cf49e4d8d6 · 2023-11-24T09:43:08.000+01:00
shutdown

Post-push test fix
Increased size of the table to ensure second call to insert_direct. The
second call to insert_direct is required to test the error path in the
DDL.

Background:
Builder::insert_direct calls m_btr_load-&gt;latch and m_btr_load-&gt;release.
The call to release will buffer fix a page. The corresponding call to
latch will unfix the above page provided m_n_recs is non-zero. This
means that the first call to latch will not do anything.

In the first call to insert_direct, latch will do nothing, but release
will buffer fix the page. In the second call to insert_direct, the test
will simulate an error in the online log and force the DDL to error out.
This way the test checks the cleanup code in the DDL. In the bug, this
cleanup had missed the latch, causing the page to remain buffer fixed -
which was caught at shutdown.

Change-Id: I70db8539c42bb4c1761b56cca5dadf814b2c5020
diff --git a/mysql-test/suite/innodb/r/builder_error_case.result b/mysql-test/suite/innodb/r/builder_error_case.result
@@ -3,7 +3,7 @@ CREATE TABLE t1 (c1 INT);
 # Create big enough table to ensure another call to Builder::insert_direct
 SELECT COUNT(*) FROM t1;
 COUNT(*)
-10001
+11000
 # Builder::insert_direct returns DB_ONLINE_LOG_TOO_BIG
 SET DEBUG="+d,builder_insert_direct_trigger_error";
 ALTER TABLE t1 ADD COLUMN c2 INT DEFAULT 20, ALGORITHM=INPLACE;
diff --git a/mysql-test/suite/innodb/t/builder_error_case.test b/mysql-test/suite/innodb/t/builder_error_case.test
@@ -12,14 +12,20 @@ DELIMITER |;
 CREATE PROCEDURE populate_t1(IN BASE INT, IN SIZE INT)
 BEGIN
   DECLARE i INT DEFAULT BASE;
-  WHILE (i <= SIZE) DO
-    INSERT INTO t1 values (i);
-    SET i = i + 1;
+  WHILE (i + 10 <= SIZE) DO
+    INSERT INTO t1 values (i), (i+1), (i+2), (i+3), (i+4), (i+5), (i+6), (i+7), (i+8), (i+9);
+    SET i = i + 10;
   END WHILE;
 END|
 DELIMITER ;|
 
-CALL populate_t1(0, 10000);
+# Note that inserting anything less than 10700 doesn't cause key_buffer to
+# overflow on 32 bit platforms - this causes a single call to
+# Builder::insert_direct. In case of 64 bit platforms, this number is 9892. The
+# reason for this difference is because of different values for sizeof the
+# Key_sort_buffer::m_dtuples on different architecture. Kept at 11000 just to be
+# ensure second call to Builder::insert_direct
+CALL populate_t1(0, 11000);
 DROP PROCEDURE populate_t1;
 --enable_query_log
 
