Bug #32702860 BROKEN BUILD ON FEDORA 34 UNDEFINED REFERENCE TO SYMBOL 'CRC32_Z@@ZLIB_1.2.9'

Tor Didriksen · dahlerlend · commit e54e5ccbedf4 · 2021-04-23T17:00:37.000+02:00
Fedora 34 comes with gcc11 and uses -flto for release builds.
This fails to build if linked wit plain ld.
/usr/bin/ld: crc32.c.o (symbol from plugin): undefined reference to symbol
'crc32_z@@ZLIB_1.2.9'

The bug is similar to
Bug #29471723 BROKEN BUILD FEDORA 28, UNDEFINED REFERENCE TO SYMBOL '__BSS_START'

This time, it is an interference between our bundled zlib, and system zlib.
We depend indirectly on system zlib via libcrypto.

Link with  -Wl,--copy-dt-needed-entries

Change-Id: Iab37cc945c834bc52ba435f378fe999ae246fefc
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -970,7 +970,8 @@ ENDIF()
 
 # Linker/binutils bug in Fedora 28, undefined reference to symbol '__bss_start'
 # Similar bug on 32bit Ubuntu.
-IF(LINUX_FEDORA_28 OR LINUX_UBUNTU_16_04)
+# Fedora 34: undefined reference to symbol 'crc32_z@@ZLIB_1.2.9'
+IF(LINUX_FEDORA_28 OR LINUX_FEDORA_34 OR LINUX_UBUNTU_16_04)
   IF(NOT CMAKE_CXX_LINK_FLAGS MATCHES "-fuse-ld=lld" AND
       NOT CMAKE_CXX_LINK_FLAGS MATCHES "-fuse-ld=gold")
     STRING_APPEND(CMAKE_CXX_LINK_FLAGS " -Wl,--copy-dt-needed-entries")
diff --git a/cmake/os/Linux.cmake b/cmake/os/Linux.cmake
@@ -46,6 +46,10 @@ IF(EXISTS "/etc/fedora-release")
       FEDORA_RELEASE MATCHES "28")
     SET(LINUX_FEDORA_28 1)
   ENDIF()
+  IF(FEDORA_RELEASE MATCHES "Fedora" AND
+      FEDORA_RELEASE MATCHES "34")
+    SET(LINUX_FEDORA_34 1)
+  ENDIF()
 ENDIF()
 
 IF(EXISTS "/etc/os-release")
