Merge pull request qltysh#131 from codeclimate/fh-engines-runner-doesnt-assume-formatter-is-closable

fhwang · fhwang · commit 2bfadcd87b31 · 2015-10-01T11:30:18.000-04:00
EnginesRunner doesn't assume formatter is closable
diff --git a/lib/cc/analyzer/engines_runner.rb b/lib/cc/analyzer/engines_runner.rb
@@ -24,7 +24,7 @@ def run(container_listener = ContainerListener.new)
 
         @formatter.finished
       ensure
-        @formatter.close
+        @formatter.close if @formatter.respond_to?(:close)
       end
 
       private
diff --git a/spec/cc/analyzer/engines_runner_spec.rb b/spec/cc/analyzer/engines_runner_spec.rb
@@ -1,4 +1,5 @@
 require "spec_helper"
+require "file_utils_ext"
 
 module CC::Analyzer
   describe EnginesRunner do
@@ -106,6 +107,22 @@ module CC::Analyzer
       end
     end
 
+    describe "when the formatter does not respond to #close" do
+      let(:config) { config_with_engine("an_engine") }
+      let(:formatter) do
+        formatter = stub(started: nil, write: nil, run: nil, finished: nil)
+        formatter.stubs(:engine_running).yields
+        formatter
+      end
+      let(:registry) { registry_with_engine("an_engine") }
+
+      it "does not call #close" do
+        expect_engine_run("an_engine", "/code", formatter)
+        FileUtils.stubs(:readable_by_all?).at_least_once.returns(true)
+        EnginesRunner.new(registry, formatter, "/code", config).run
+      end
+    end
+
     def registry_with_engine(name)
       { name => { "image" => "codeclimate/codeclimate-#{name}" } }
     end
