Refactor dependencies command to prepare

wfleming · wfleming · commit 41093732d927 · 2016-11-11T14:37:08.000-05:00
Reflecting the change in yaml key names, the command will also be called prepare now
diff --git a/lib/cc/cli.rb b/lib/cc/cli.rb
@@ -11,9 +11,9 @@ module CLI
     autoload :Command, "cc/cli/command"
     autoload :Console, "cc/cli/console"
     autoload :Engines, "cc/cli/engines"
-    autoload :Dependencies, "cc/cli/dependencies"
     autoload :Help, "cc/cli/help"
     autoload :Init, "cc/cli/init"
+    autoload :Prepare, "cc/cli/prepare"
     autoload :Runner, "cc/cli/runner"
     autoload :Test, "cc/cli/test"
     autoload :ValidateConfig, "cc/cli/validate_config"
diff --git a/lib/cc/cli/help.rb b/lib/cc/cli/help.rb
@@ -21,7 +21,7 @@ def commands
           "engines:install",
           "engines:list",
           "engines:remove #{underline("engine_name")}",
-          "dependencies",
+          "prepare",
           "help",
           "init",
           "validate-config",
diff --git a/lib/cc/cli/prepare.rb b/lib/cc/cli/prepare.rb
@@ -9,7 +9,7 @@
 
 module CC
   module CLI
-    class Dependencies < Command
+    class Prepare < Command
       InternalHostError = Class.new(StandardError)
       FetchError = Class.new(StandardError)
 
@@ -24,10 +24,10 @@ class Dependencies < Command
 
       def run
         require_codeclimate_yml
-        fatal("No file dependencies configured") unless files.present?
+        fatal("No fetches configured") unless fetches.present?
 
         ::CC::Resolv.with_fixed_dns { fetch_all }
-        success("All file dependencies fetched")
+        success("All fetches fetched")
       rescue FetchError, InternalHostError => ex
         fatal(ex.message)
       end
@@ -38,16 +38,16 @@ def allow_internal_ips?
         @args.include?("--allow-internal-ips")
       end
 
-      def files
-        @files ||= config.dependencies && config.dependencies.files
+      def fetches
+        @fetches ||= config[:prepare] && config[:prepare].fetch
       end
 
       def config
         @config ||= CC::Yaml.parse(filesystem.read_path(CODECLIMATE_YAML))
       end
 
       def fetch_all
-        files.each do |entry|
+        fetches.each do |entry|
           fetch(entry.url, entry.path)
         end
       end
diff --git a/spec/cc/cli/prepare_spec.rb b/spec/cc/cli/prepare_spec.rb
@@ -1,13 +1,13 @@
 require "spec_helper"
 
 module CC::CLI
-  describe Dependencies do
+  describe Prepare do
     include FileSystemHelpers
     include ProcHelpers
 
     FIXTURE_CONFIG = <<YAML
-dependencies:
-  files:
+prepare:
+  fetch:
   - url: "http://example.com/foo.json"
     path: bar.json
 YAML
@@ -23,7 +23,7 @@ module CC::CLI
 
         stub_resp("example.com", "255.255.255.255", resp)
         stdout, stderr = capture_io do
-          Dependencies.new.run
+          Prepare.new.run
         end
         expect(stdout).to match("Wrote http://example.com/foo.json to bar.json")
 
@@ -37,7 +37,7 @@ module CC::CLI
 
         stub_resp("example.com", "127.0.0.1", resp)
         stdout, stderr, _ = capture_io_and_exit_code do
-          Dependencies.new.run
+          Prepare.new.run
         end
         expect(stderr).to match("maps to an internal address")
 
@@ -50,7 +50,7 @@ module CC::CLI
 
         stub_resp("example.com", "127.0.0.1", resp)
         stdout, stderr = capture_io do
-          Dependencies.new(["--allow-internal-ips"]).run
+          Prepare.new(["--allow-internal-ips"]).run
         end
         expect(stdout).to match("Wrote http://example.com/foo.json to bar.json")
 
@@ -64,7 +64,7 @@ module CC::CLI
 
         stub_resp("example.com", "255.255.255.255", resp)
         stdout, stderr, _ = capture_io_and_exit_code do
-          Dependencies.new.run
+          Prepare.new.run
         end
         expect(stderr).to match("Failed fetching")
 
