make email address filtering optional

oreoshake · oreoshake · commit e00d56447cfc · 2016-03-29T14:18:00.000-10:00
diff --git a/lib/html/pipeline/email_reply_filter.rb b/lib/html/pipeline/email_reply_filter.rb
@@ -47,10 +47,12 @@ def call
         paragraphs = EmailReplyParser.read(text.dup).fragments.map do |fragment|
           pieces = [escape_html(fragment.to_s.strip).gsub(/^\s*(>|&gt;)/, '')]
           if fragment.quoted?
-            pieces.map! do |piece|
-              lines = piece.lines
-              lines.first.gsub!(EMAIL_REGEX, HIDDEN_EMAIL_PATTERN)
-              lines
+            if context[:hide_quoted_email_addresses]
+              pieces.map! do |piece|
+                lines = piece.lines
+                lines.first.gsub!(EMAIL_REGEX, HIDDEN_EMAIL_PATTERN)
+                lines
+              end
             end
             pieces.unshift EMAIL_QUOTED_HEADER
             pieces << EMAIL_HEADER_END
diff --git a/test/html/pipeline/email_reply_filter_test.rb b/test/html/pipeline/email_reply_filter_test.rb
@@ -3,8 +3,8 @@
 EmailReplyFilter = HTML::Pipeline::EmailReplyFilter
 
 class HTML::Pipeline::EmailReplyFilterTest < Minitest::Test
-  def test_hides_email_addresses
-    filter = EmailReplyFilter.new(<<-EMAIL, :highlight => "coffeescript")
+  def setup
+    @body = <<-EMAIL
 Hey, don't send email addresses in comments. They aren't filtered.
 
 > On Mar 5, 2016, at 08:05, Hacker J. Hackerson <example@example.com> wrote:
@@ -15,9 +15,19 @@ def test_hides_email_addresses
 > Reply to this email directly or view it on GitHub.
 >
 EMAIL
+  end
+
+  def test_doesnt_hide_by_default
+    filter = EmailReplyFilter.new(@body)
+    doc = filter.call.to_s
+    assert_match %r(example@example.com), doc
+    assert_match %r(alreadyleaked@example.com), doc
+  end
 
-    doc = filter.call
-    refute_match %r(example@example.com), doc.to_s
-    assert_match %r(alreadyleaked@example.com), doc.to_s
+  def test_hides_email_addresses_when_configured
+    filter = EmailReplyFilter.new(@body, :hide_quoted_email_addresses => true)
+    doc = filter.call.to_s
+    refute_match %r(example@example.com), doc
+    assert_match %r(alreadyleaked@example.com), doc
   end
 end
