add: implementation of setter injection (refactored from parameter injection)

Florian Kromer · Florian Kromer · commit 0105c9a03fdc · 2017-04-06T23:26:50.000+02:00
diff --git a/dft/setter_injection.py b/dft/setter_injection.py
@@ -3,7 +3,7 @@
 import datetime
 
 """
-Port of the Java example of "Parameter Injection" in
+Port of the Java example of "Setter Injection" in
 "xUnit Test Patterns - Refactoring Test Code" by Gerard Meszaros
 (ISBN-10: 0131495054, ISBN-13: 978-0131495050) accessible in outdated version on
 http://xunitpatterns.com/Dependency%20Injection.html.
@@ -26,8 +26,11 @@ class TimeDisplay(object):
     def __init__(self):
         pass
 
-    def get_current_time_as_html_fragment(self, time_provider):
-        current_time = time_provider.now()
+    def set_time_provider(self, time_provider):
+        self.time_provider = time_provider
+
+    def get_current_time_as_html_fragment(self):
+        current_time = self.time_provider.now()
         current_time_as_html_fragment = "<span class=\"tinyBoldText\">" + current_time + "</span>"
         return current_time_as_html_fragment
 
diff --git a/tests/test_setter_injection.py b/tests/test_setter_injection.py
@@ -2,10 +2,10 @@
 # -*- coding: utf-8 -*-
 import unittest
 
-from dft.parameter_injection import TimeDisplay, MidnightTimeProvider, ProductionCodeTimeProvider, datetime
+from dft.setter_injection import TimeDisplay, MidnightTimeProvider, ProductionCodeTimeProvider, datetime
 
 """
-Port of the Java example of "Parameter Injection" in
+Port of the Java example of "Setter Injection" in
 "xUnit Test Patterns - Refactoring Test Code" by Gerard Meszaros
 (ISBN-10: 0131495054, ISBN-13: 978-0131495050) accessible in outdated version on
 http://xunitpatterns.com/Dependency%20Injection.html.
@@ -29,8 +29,9 @@ def test_display_current_time_at_midnight(self):
         """
         time_provider_stub = MidnightTimeProvider()
         class_under_test = TimeDisplay()
+        class_under_test.set_time_provider(time_provider_stub)
         expected_time = "<span class=\"tinyBoldText\">24:01</span>"
-        self.assertEqual(class_under_test.get_current_time_as_html_fragment(time_provider_stub), expected_time)
+        self.assertEqual(class_under_test.get_current_time_as_html_fragment(), expected_time)
 
     def test_display_current_time_at_current_time(self):
         """
@@ -39,6 +40,7 @@ def test_display_current_time_at_current_time(self):
         """
         production_code_time_provider = ProductionCodeTimeProvider()
         class_under_test = TimeDisplay()
+        class_under_test.set_time_provider(production_code_time_provider)
         current_time = datetime.datetime.now()
         expected_time = "<span class=\"tinyBoldText\">" + str(current_time.hour) + ":" + str(current_time.minute) + "</span>"
-        self.assertEqual(class_under_test.get_current_time_as_html_fragment(production_code_time_provider), expected_time)
+        self.assertEqual(class_under_test.get_current_time_as_html_fragment(), expected_time)
