Skip to content

Commit 0b529cb

Browse files
authored
[Fix] gpu size calculation for PIXELFORMAT_L8_A8 and mipmaps (playcanvas#2350)
* [Fix] gpu size calculation for PIXELFORMAT_L8_A8 and mipmaps * lint fix
1 parent 75cebd3 commit 0b529cb

File tree

1 file changed

+3
-10
lines changed

1 file changed

+3
-10
lines changed

src/graphics/texture.js

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { math } from '../math/math.js';
22

33
import {
44
ADDRESS_REPEAT,
5-
FILTER_LINEAR, FILTER_NEAREST_MIPMAP_NEAREST, FILTER_NEAREST_MIPMAP_LINEAR, FILTER_LINEAR_MIPMAP_NEAREST, FILTER_LINEAR_MIPMAP_LINEAR,
5+
FILTER_LINEAR, FILTER_LINEAR_MIPMAP_LINEAR,
66
FUNC_LESS,
77
PIXELFORMAT_A8, PIXELFORMAT_L8, PIXELFORMAT_L8_A8, PIXELFORMAT_R5_G6_B5, PIXELFORMAT_R5_G5_B5_A1, PIXELFORMAT_R4_G4_B4_A4,
88
PIXELFORMAT_R8_G8_B8, PIXELFORMAT_R8_G8_B8_A8, PIXELFORMAT_DXT1, PIXELFORMAT_DXT3, PIXELFORMAT_DXT5,
@@ -500,14 +500,7 @@ Object.defineProperties(Texture.prototype, {
500500

501501
gpuSize: {
502502
get: function () {
503-
var mips = this.pot &&
504-
(this._mipmaps ||
505-
this._minFilter === FILTER_NEAREST_MIPMAP_NEAREST ||
506-
this._minFilter === FILTER_NEAREST_MIPMAP_LINEAR ||
507-
this._minFilter === FILTER_LINEAR_MIPMAP_NEAREST ||
508-
this._minFilter === FILTER_LINEAR_MIPMAP_LINEAR) &&
509-
!(this._compressed && this._levels.length === 1);
510-
503+
var mips = this.pot && this._mipmaps && !(this._compressed && this._levels.length === 1);
511504
return Texture.calcGpuSize(this._width, this._height, this._depth, this._format, mips, this._cubemap);
512505
}
513506
},
@@ -591,7 +584,7 @@ Object.assign(Texture, {
591584
_pixelSizeTable = [];
592585
_pixelSizeTable[PIXELFORMAT_A8] = 1;
593586
_pixelSizeTable[PIXELFORMAT_L8] = 1;
594-
_pixelSizeTable[PIXELFORMAT_L8_A8] = 1;
587+
_pixelSizeTable[PIXELFORMAT_L8_A8] = 2;
595588
_pixelSizeTable[PIXELFORMAT_R5_G6_B5] = 2;
596589
_pixelSizeTable[PIXELFORMAT_R5_G5_B5_A1] = 2;
597590
_pixelSizeTable[PIXELFORMAT_R4_G4_B4_A4] = 2;

0 commit comments

Comments
 (0)