Skip to content

Commit 0ce546b

Browse files
committed
remove some commented out stuff
1 parent dbc3165 commit 0ce546b

File tree

1 file changed

+2
-15
lines changed

1 file changed

+2
-15
lines changed

src/framework/components/element/text-element.js

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -248,6 +248,8 @@ Object.assign(pc, function () {
248248
_updateMeshInfos: function () {
249249
var i;
250250

251+
// make sure we have as many meshInfo entries
252+
// as the number of font textures and outline passes
251253
var multiPassNeeded = (this._outlineThickness > 1.0 && this._outlineColor.a > 0);
252254

253255
var passes = [];
@@ -1583,11 +1585,9 @@ Object.assign(pc, function () {
15831585
set: function (value) {
15841586

15851587
var previousFontType;
1586-
// var previousFontVersion;
15871588

15881589
if (this._font) {
15891590
previousFontType = this._font.type;
1590-
// previousFontVersion = this._font.data.version;
15911591

15921592
// remove render event listener
15931593
if (this._font.off) this._font.off('render', this._onFontRender, this);
@@ -1628,22 +1628,9 @@ Object.assign(pc, function () {
16281628
this._updateMaterial(screenSpace);
16291629
}
16301630

1631-
// make sure we have as many meshInfo entries
1632-
// as the number of font textures and outline passes
1633-
16341631
this._multiPassEnabled = !(this._outlineThickness > 1.0 && this._outlineColor.a > 0); // this line forces a call to _updateMeshInfos
16351632

16361633
this._updateText();
1637-
1638-
// if font version has changed we will need to change the _outlineThicknessScale and update the material parameter
1639-
// if (value.data.version !== previousFontVersion) {
1640-
// this._outlineThicknessScale = (this._font.data.version == 3) ? 0.2 : 0.1;
1641-
//
1642-
// for (var i = 0; i < this._model.meshInstances.length; i++) {
1643-
// var mi = this._model.meshInstances[i];
1644-
// mi.setParameter("outline_thickness", this._outlineThicknessScale * Math.min(this._outlineThickness,(this._font.data.version==3) ? 1.0 : 5.0));
1645-
// }
1646-
// }
16471634
}
16481635
});
16491636

0 commit comments

Comments
 (0)