[FIX] Source map is no longer offset (playcanvas#2013)

yaustar · Steven Yau · willeastcott · web-flow · commit 548f09014326 · 2020-04-30T18:15:37.000+01:00
Added note in the readme about the preprocessor breaking source maps and is therefore ignored
Moved copyright to the end of the built file if source map is being built
Fixed ignoring the preprocessor if source map is being built

Co-authored-by: Steven Yau &lt;syau@snaphcat.com&gt;
Co-authored-by: Will Eastcott &lt;will@playcanvas.com&gt;
diff --git a/README.md b/README.md
@@ -149,6 +149,8 @@ To build the source map to allow for easier engine debugging, you can add `-- -m
 
 This will output to `build/output/playcanvas.js.map`
 
+Note: The preprocessor is ignored when when generating the source map as it breaks the mapping. This means that all debug and profiling code is included in the engine build when generating the source map.
+
 ## How to run tests
 
 PlayCanvas uses of Karma for unit testing. There are three ways of running the tests:
diff --git a/build/build.js b/build/build.js
@@ -163,7 +163,7 @@ var preprocess = function (dependencies) {
         var pp = new Preprocessor(buffer.toString());
         var src;
         // TODO: source mapped build doesn't support preprocessor yet
-        if(this.sourceMap)
+        if(sourceMap)
             src = buffer;
         else 
             src = pp.process({
@@ -210,7 +210,14 @@ var insertVersions = function (filepath, callback) {
 
                 var content = buffer.toString();
 
-                content = getCopyrightNotice(ver, rev) + content;
+                // Add the copyright notice to the end if we are creating sourcemaps
+                // otherwise we offset the mappings
+                if (sourceMap) {
+                    content = content + "\n" + getCopyrightNotice(ver, rev);
+                } else {
+                    content = getCopyrightNotice(ver, rev) + content;
+                }
+
                 content = replaceAll(content, "__CURRENT_SDK_VERSION__", ver);
                 content = replaceAll(content, "__REVISION__", rev);
 
