Fix to culling of non-moving skinned objects (playcanvas#3330)

mvaligursky · Martin Valigursky · web-flow · commit 7fcdb9cf5b44 · 2021-07-13T04:33:29.000-07:00
* Fix to culling of non-moving skinned objects

* removing one more reference to _radiusVer

Co-authored-by: Martin Valigursky &lt;mvaligursky@snapchat.com&gt;
diff --git a/src/scene/batching/batch.js b/src/scene/batching/batch.js
@@ -54,7 +54,6 @@ class Batch {
             this._aabb.add(this.origMeshInstances[i].aabb);
         }
         this.meshInstance.aabb = this._aabb;
-        this._aabb._radiusVer = -1;
         this.meshInstance._aabbVer = 0;
     }
 }
diff --git a/src/scene/mesh-instance.js b/src/scene/mesh-instance.js
@@ -521,14 +521,8 @@ class MeshInstance {
                 return this.isVisibleFunc(camera);
             }
 
-            var pos = this.aabb.center;
-            if (this._aabb._radiusVer !== this._aabbVer) {
-                this._aabb._radius = this._aabb.halfExtents.length();
-                this._aabb._radiusVer = this._aabbVer;
-            }
-
-            _tempSphere.radius = this._aabb._radius;
-            _tempSphere.center = pos;
+            _tempSphere.center = this.aabb.center;  // this line evaluates aabb
+            _tempSphere.radius = this._aabb.halfExtents.length();
 
             return camera.frustum.containsSphere(_tempSphere);
         }

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,6 @@ class Batch {`
`54`	`54`	`this._aabb.add(this.origMeshInstances[i].aabb);`
`55`	`55`	`}`
`56`	`56`	`this.meshInstance.aabb = this._aabb;`
`57`		`- this._aabb._radiusVer = -1;`
`58`	`57`	`this.meshInstance._aabbVer = 0;`
`59`	`58`	`}`
`60`	`59`	`}`