[FIX] Fix various function declarations (playcanvas#2895)

willeastcott · web-flow · commit 8ef91527e08b · 2021-02-21T13:55:27.000Z
* [FIX] Fix XrTrackedImage#destroy

* More function declaration fixes

* More function declaration fixes

* Another function fix

* Lint fix
diff --git a/src/scene/particle-system/gpu-updater.js b/src/scene/particle-system/gpu-updater.js
@@ -75,7 +75,7 @@ class ParticleGPUUpdater {
         this.constantInBoundsCenter.setValue(this.inBoundsCenterUniform);
     }
 
-    randomize = function () {
+    randomize() {
         this.frameRandomUniform[0] = Math.random();
         this.frameRandomUniform[1] = Math.random();
         this.frameRandomUniform[2] = Math.random();
diff --git a/src/scene/particle-system/particle-emitter.js b/src/scene/particle-system/particle-emitter.js
@@ -50,7 +50,7 @@ const particleVerts = [
     [-1, 1]
 ];
 
-var _createTexture = function (device, width, height, pixelData, format = PIXELFORMAT_RGBA32F, mult8Bit, filter) {
+function _createTexture(device, width, height, pixelData, format = PIXELFORMAT_RGBA32F, mult8Bit, filter) {
 
     var mipFilter = FILTER_NEAREST;
     if (filter && format === PIXELFORMAT_R8_G8_B8_A8)
@@ -84,7 +84,7 @@ var _createTexture = function (device, width, height, pixelData, format = PIXELF
     texture.unlock();
 
     return texture;
-};
+}
 
 function saturate(x) {
     return Math.max(Math.min(x, 1), 0);
diff --git a/src/script/script-registry.js b/src/script/script-registry.js
@@ -221,7 +221,7 @@ class ScriptRegistry extends EventHandler {
      * }));
      */
     /* eslint-enable jsdoc/no-undefined-types */
-    list = function () {
+    list() {
         return this._list;
     }
 }
diff --git a/src/xr/xr-hand.js b/src/xr/xr-hand.js
@@ -79,7 +79,7 @@ class XrHand extends EventHandler {
      * @description Fired when tracking is lost.
      */
 
-    update = function (frame) {
+    update(frame) {
         var xrInputSource = this._inputSource._xrInputSource;
 
         // joints
diff --git a/src/xr/xr-input-source.js b/src/xr/xr-input-source.js
@@ -229,7 +229,7 @@ class XrInputSource extends EventHandler {
         }
     }
 
-    _updateRayTransforms = function () {
+    _updateRayTransforms() {
         var dirty = this._dirtyRay;
         this._dirtyRay = false;
 
@@ -295,7 +295,7 @@ class XrInputSource extends EventHandler {
      * @description Get the local space rotation of input source if it is handheld ({@link XrInputSource#grip} is true). Local space is relative to parent of the XR camera. Otherwise it will return null.
      * @returns {Vec3|null} The world space rotation of handheld input source.
      */
-    getLocalRotation = function () {
+    getLocalRotation() {
         return this._localRotation;
     }
 
@@ -305,7 +305,7 @@ class XrInputSource extends EventHandler {
      * @description Get the world space origin of input source ray.
      * @returns {Vec3} The world space origin of input source ray.
      */
-    getOrigin = function () {
+    getOrigin() {
         this._updateRayTransforms();
         return this._ray.origin;
     }
diff --git a/src/xr/xr-tracked-image.js b/src/xr/xr-tracked-image.js
@@ -64,7 +64,7 @@ class XrTrackedImage extends EventHandler {
             });
     }
 
-    destroy = function () {
+    destroy() {
         this._image = null;
         this._pose = null;
 
@@ -97,7 +97,7 @@ class XrTrackedImage extends EventHandler {
      * // update entity rotation to match tracked image rotation
      * entity.setRotation(trackedImage.getRotation());
      */
-    getRotation = function () {
+    getRotation() {
         if (this._pose) this._rotation.copy(this._pose.transform.orientation);
         return this._rotation;
     }

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ class ParticleGPUUpdater {`
`75`	`75`	`this.constantInBoundsCenter.setValue(this.inBoundsCenterUniform);`
`76`	`76`	`}`
`77`	`77`
`78`		`- randomize = function () {`
	`78`	`+ randomize() {`
`79`	`79`	`this.frameRandomUniform[0] = Math.random();`
`80`	`80`	`this.frameRandomUniform[1] = Math.random();`
`81`	`81`	`this.frameRandomUniform[2] = Math.random();`
Original file line number	Diff line number	Diff line change
`@@ -221,7 +221,7 @@ class ScriptRegistry extends EventHandler {`
`221`	`221`	`* }));`
`222`	`222`	`*/`
`223`	`223`	`/* eslint-enable jsdoc/no-undefined-types */`
`224`		`- list = function () {`
	`224`	`+ list() {`
`225`	`225`	`return this._list;`
`226`	`226`	`}`
`227`	`227`	`}`
Original file line number	Diff line number	Diff line change
`@@ -229,7 +229,7 @@ class XrInputSource extends EventHandler {`
`229`	`229`	`}`
`230`	`230`	`}`
`231`	`231`
`232`		`- _updateRayTransforms = function () {`
	`232`	`+ _updateRayTransforms() {`
`233`	`233`	`var dirty = this._dirtyRay;`
`234`	`234`	`this._dirtyRay = false;`
`235`	`235`
`@@ -295,7 +295,7 @@ class XrInputSource extends EventHandler {`
`295`	`295`	`* @description Get the local space rotation of input source if it is handheld ({@link XrInputSource#grip} is true). Local space is relative to parent of the XR camera. Otherwise it will return null.`
`296`	`296`	`* @returns {Vec3\|null} The world space rotation of handheld input source.`
`297`	`297`	`*/`
`298`		`- getLocalRotation = function () {`
	`298`	`+ getLocalRotation() {`
`299`	`299`	`return this._localRotation;`
`300`	`300`	`}`
`301`	`301`
`@@ -305,7 +305,7 @@ class XrInputSource extends EventHandler {`
`305`	`305`	`* @description Get the world space origin of input source ray.`
`306`	`306`	`* @returns {Vec3} The world space origin of input source ray.`
`307`	`307`	`*/`
`308`		`- getOrigin = function () {`
	`308`	`+ getOrigin() {`
`309`	`309`	`this._updateRayTransforms();`
`310`	`310`	`return this._ray.origin;`
`311`	`311`	`}`