Revert "Remove gl canvas dependency resize (playcanvas#3124)" (playcanvas#3146)

yaustar · steveny-sc · web-flow · commit ebcdfc334c11 · 2021-05-06T10:02:12.000+01:00
This reverts commit b2aaa7b. Co-authored-by: Steven Yau <syau@snapchat.com>
diff --git a/src/framework/application.js b/src/framework/application.js
@@ -1390,6 +1390,11 @@ class Application extends EventHandler {
         this.graphicsDevice.canvas.style.width = width + 'px';
         this.graphicsDevice.canvas.style.height = height + 'px';
 
+        // In AUTO mode the resolution is changed to match the canvas size
+        if (this._resolutionMode === RESOLUTION_AUTO) {
+            this.setCanvasResolution(RESOLUTION_AUTO);
+        }
+
         // return the final values calculated for width and height
         return {
             width: width,
@@ -2141,13 +2146,6 @@ var makeTick = function (_app) {
         application.fire("framerender");
 
         if (application.autoRender || application.renderNextFrame) {
-            // In AUTO mode the resolution is changed to match the canvas size
-            if (application._resolutionMode === RESOLUTION_AUTO) {
-                // Check if the canvas DOM has changed size
-                const canvas = application.graphicsDevice.canvas;
-                application.graphicsDevice.resizeCanvas(canvas.clientWidth, canvas.clientHeight);
-            }
-
             application.render();
             application.renderNextFrame = false;
         }
diff --git a/src/graphics/graphics-device.js b/src/graphics/graphics-device.js
@@ -3482,7 +3482,6 @@ class GraphicsDevice extends EventHandler {
     }
 
     /**
-     * @private
      * @function
      * @name GraphicsDevice#resizeCanvas
      * @description Sets the width and height of the canvas, then fires the 'resizecanvas' event.
@@ -3497,8 +3496,8 @@ class GraphicsDevice extends EventHandler {
         this._height = height;
 
         var ratio = Math.min(this._maxPixelRatio, window.devicePixelRatio);
-        width = Math.floor(width * ratio);
-        height = Math.floor(height * ratio);
+        width *= ratio;
+        height *= ratio;
 
         if (this.canvas.width === width && this.canvas.height === height)
             return;
