fixed a bug of not resolving the Promise when detectSingleFace returns no result

justadudewhohacks · justadudewhohacks · commit 08dcf8304fe0 · 2019-01-02T10:01:11.000+01:00
diff --git a/src/globalApi/DetectFacesTasks.ts b/src/globalApi/DetectFacesTasks.ts
@@ -90,7 +90,7 @@ export class DetectSingleFaceTask extends DetectFacesTaskBase<FaceDetection | un
   private runAndExtendWithFaceDetection(): Promise<WithFaceDetection<{}>> {
     return new Promise<WithFaceDetection<{}>>(async res => {
       const detection = await this.run()
-      return detection ? res(extendWithFaceDetection<{}>({}, detection)) : null
+      return res(detection ? extendWithFaceDetection<{}>({}, detection) : undefined)
     })
   }
 

Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,7 @@ export class DetectSingleFaceTask extends DetectFacesTaskBase<FaceDetection \| un`
`90`	`90`	`private runAndExtendWithFaceDetection(): Promise<WithFaceDetection<{}>> {`
`91`	`91`	`return new Promise<WithFaceDetection<{}>>(async res => {`
`92`	`92`	`const detection = await this.run()`
`93`		`- return detection ? res(extendWithFaceDetection<{}>({}, detection)) : null`
	`93`	`+ return res(detection ? extendWithFaceDetection<{}>({}, detection) : undefined)`
`94`	`94`	`})`
`95`	`95`	`}`
`96`	`96`