fixed score distance calculation + increase descriptor delta

justadudewhohacks · justadudewhohacks · commit b8841daae7e4 · 2018-10-30T12:56:59.000+01:00
diff --git a/test/expectFullFaceDescriptions.ts b/test/expectFullFaceDescriptions.ts
@@ -25,7 +25,7 @@ export function expectFullFaceDescriptions(
 
   expectedFullFaceDescriptions.forEach((expected, i) => {
     const { detection, landmarks, descriptor } = sortedResults[i]
-    expect(detection.score - expected.score).toBeLessThan(deltas.maxScoreDelta)
+    expect(Math.abs(detection.score - expected.score)).toBeLessThan(deltas.maxScoreDelta)
     expectRectClose(detection.box, expected.detection, deltas.maxBoxDelta)
     landmarks.positions.forEach((pt, j) => expectPointClose(pt, expected.landmarks[j], deltas.maxLandmarksDelta))
     expect(euclideanDistance(descriptor, expected.descriptor)).toBeLessThan(deltas.maxDescriptorDelta)
diff --git a/test/tests/ssdMobilenetv1/ssdMobilenetv1.test.ts b/test/tests/ssdMobilenetv1/ssdMobilenetv1.test.ts
@@ -64,7 +64,7 @@ describe('ssdMobilenetv1', () => {
         maxScoreDelta: 0.01,
         maxBoxDelta: 5,
         maxLandmarksDelta: 2,
-        maxDescriptorDelta: 0.1
+        maxDescriptorDelta: 0.2
       }
       expect(results.length).toEqual(6)
       expectFullFaceDescriptions(results, expectedFullFaceDescriptions, expectedScores, deltas)

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ describe('ssdMobilenetv1', () => {`
`64`	`64`	`maxScoreDelta: 0.01,`
`65`	`65`	`maxBoxDelta: 5,`
`66`	`66`	`maxLandmarksDelta: 2,`
`67`		`- maxDescriptorDelta: 0.1`
	`67`	`+ maxDescriptorDelta: 0.2`
`68`	`68`	`}`
`69`	`69`	`expect(results.length).toEqual(6)`
`70`	`70`	`expectFullFaceDescriptions(results, expectedFullFaceDescriptions, expectedScores, deltas)`