making number type test more foolproof

chrisdavidmills · chrisdavidmills · commit 10137f33f2c3 · 2020-04-17T12:04:49.000+01:00
diff --git a/javascript/introduction-to-js-1/tasks/math/math2-download.html b/javascript/introduction-to-js-1/tasks/math/math2-download.html
@@ -39,7 +39,7 @@
     let para1 = document.createElement('p');
     para1.textContent = `Your finalResult is ${ finalResult }`;
     let para2 = document.createElement('p');
-    let finalNumberCheck = typeof finalNumber === 'number' ? 'finalNumber is a number type. Well done!' : `Ooops! finalNumber is of type ${ typeof finalNumber }.`
+    let finalNumberCheck = isNaN(finalNumber) === false ? 'finalNumber is a number type. Well done!' : `Ooops! finalNumber is not a number.`;
     para2.textContent = finalNumberCheck;
 
     section.appendChild(para1);
diff --git a/javascript/introduction-to-js-1/tasks/math/math2.html b/javascript/introduction-to-js-1/tasks/math/math2.html
@@ -37,7 +37,7 @@
 let para1 = document.createElement('p');
 para1.textContent = `Your finalResult is ${ finalResult }`;
 let para2 = document.createElement('p');
-let finalNumberCheck = typeof finalNumber === 'number' ? 'finalNumber is a number type. Well done!' : `Ooops! finalNumber is of type ${ typeof finalNumber }.`
+let finalNumberCheck = isNaN(finalNumber) === false ? 'finalNumber is a number type. Well done!' : `Ooops! finalNumber is not a number.`;
 para2.textContent = finalNumberCheck;
 
 section.appendChild(para1);
