Fix nwjs#7593: nw2 Window removing listeners on 'loaded' event

rogerwang · rogerwang · commit a6496ddb9f07 · 2020-10-16T02:04:38.000-06:00
diff --git a/src/resources/api_nw_newwin.js b/src/resources/api_nw_newwin.js
@@ -54,7 +54,6 @@ var nwWinEventsMap = {
 };
 
 var nwWrapEventsMap = {
-  'loaded':           'LoadingStateChanged',
   'new-win-policy':   'onNewWinPolicy',
   'navigation':       'onNavigation'
 };
@@ -265,6 +264,14 @@ NWWindow.prototype.on = function (event, callback, record) {
   return this;
 };
 NWWindow.prototype.removeListener = function (event, callback) {
+  if (event === 'loaded') {
+    for (let l of chrome.tabs.onUpdated.getListeners()) {
+      if (l.listener && l.listener === callback) {
+        chrome.tabs.onUpdated.removeListener(l);
+        return this;
+      }
+    }
+  }
   if (nwWinEventsMap.hasOwnProperty(event)) {
     for (let l of this[nwWinEventsMap[event]].getListeners()) {
       if (l.listener && l.listener === callback) {
@@ -320,6 +327,12 @@ NWWindow.prototype.removeAllListeners = function (event) {
     }
     return this;
   }
+  if (event === 'loaded') {
+    for (let l of chrome.tabs.onUpdated.getListeners()) {
+      chrome.tabs.onUpdated.removeListener(l);
+    }
+    return this;
+  }
   return this;
 };
 
