Skip to content

Commit bc5421b

Browse files
pmdartuspmdartus
authored
fix(engine-server): match declarative shadow output with latest spec (salesforce#1968)
1 parent 3fbdc17 commit bc5421b

File tree

44 files changed

+134
-100
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+134
-100
lines changed

‎packages/@lwc/engine-server/src/__tests__/fixtures/attribute-boolean/expected.html

100755100644
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<x-attribute-boolean>
2-
<template shadow-root>
2+
<template shadowroot="open">
33
<input type="checkbox" required readonly checked />
44
</template>
55
</x-attribute-boolean>

‎packages/@lwc/engine-server/src/__tests__/fixtures/attribute-component-aria/expected.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
<x-attribute-component-aria>
2-
<template shadow-root>
2+
<template shadowroot="open">
33
<x-child
44
role="progressbar"
55
aria-valuemin="0"
66
aria-valuemax="100"
77
aria-valuenow="20"
88
>
9-
<template shadow-root></template>
9+
<template shadowroot="open"></template>
1010
</x-child>
1111
</template>
1212
</x-attribute-component-aria>

‎packages/@lwc/engine-server/src/__tests__/fixtures/attribute-component-global-html/expected.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<x-attribute-component-global-html>
2-
<template shadow-root>
2+
<template shadowroot="open">
33
<x-child
44
data-test="test"
55
accesskey="A"
@@ -13,7 +13,7 @@
1313
class="foo bar"
1414
style="color: red; background: blue;"
1515
>
16-
<template shadow-root>
16+
<template shadowroot="open">
1717
Passthrough properties:
1818
<ul>
1919
<li>Title: foo</li>

‎packages/@lwc/engine-server/src/__tests__/fixtures/attribute-dynamic/expected.html

100755100644
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<x-attribute-dynamic>
2-
<template shadow-root>
2+
<template shadowroot="open">
33
<div data-foo="foo" class="foo" style="color: red;"></div>
44
</template>
55
</x-attribute-dynamic>

‎packages/@lwc/engine-server/src/__tests__/fixtures/attribute-global-html/expected.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<x-attribute-global-html>
2-
<template shadow-root>
2+
<template shadowroot="open">
33
<div
44
accesskey="A"
55
contenteditable="true"

‎packages/@lwc/engine-server/src/__tests__/fixtures/attribute-live-bindings/expected.html

100755100644
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<x-attribute-live-bindings>
2-
<template shadow-root>
2+
<template shadowroot="open">
33
<p>
44
Checked:
55
<input type="checkbox" checked />

‎packages/@lwc/engine-server/src/__tests__/fixtures/attribute-static/expected.html

100755100644
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<x-attribute-static>
2-
<template shadow-root>
2+
<template shadowroot="open">
33
<div
44
data-foo="foo"
55
class="foo bar foo-bar"

‎packages/@lwc/engine-server/src/__tests__/fixtures/attribute-style/expected.html

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,22 @@
11
<x-attribute-style>
2-
<template shadow-root>
2+
<template shadowroot="open">
33
<div style="color: red;"></div>
44
<div style="color: blue; background: black; border: 1px solid red;"></div>
55
<div
66
style="border-width: 1px; border-style: solid; border-color: red;"
77
></div>
88
<div style="color: salmon; background-color: chocolate;"></div>
9-
<x-child style="color: red;"><template shadow-root></template></x-child>
9+
<x-child style="color: red;">
10+
<template shadowroot="open"></template>
11+
</x-child>
1012
<x-child style="color: blue; background: black; border: 1px solid red;">
11-
<template shadow-root></template>
13+
<template shadowroot="open"></template>
1214
</x-child>
1315
<x-child style="border-width: 1px; border-style: solid; border-color: red;">
14-
<template shadow-root></template>
16+
<template shadowroot="open"></template>
1517
</x-child>
1618
<x-child style="color: salmon; background-color: chocolate;">
17-
<template shadow-root></template>
19+
<template shadowroot="open"></template>
1820
</x-child>
1921
</template>
2022
</x-attribute-style>

‎packages/@lwc/engine-server/src/__tests__/fixtures/attributes-aria/expected.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<x-attributes-aria>
2-
<template shadow-root>
2+
<template shadowroot="open">
33
<span id="label-id-0">This is a section</span>
44
<div aria-describedby="label-id-0">I am section</div>
55
<div

‎packages/@lwc/engine-server/src/__tests__/fixtures/component/expected.html

100755100644
Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
<x-component>
2-
<template shadow-root>
3-
<x-child><template shadow-root>I am a child component</template></x-child>
2+
<template shadowroot="open">
3+
<x-child>
4+
<template shadowroot="open">I am a child component</template>
5+
</x-child>
46
</template>
57
</x-component>

0 commit comments

Comments
 (0)