test(engine-server): Improve test coverage (salesforce#1950)

pmdartus · web-flow · commit bd8005708c57 · 2020-06-30T10:12:58.000+02:00
diff --git a/packages/@lwc/engine-core/src/framework/renderer.ts b/packages/@lwc/engine-core/src/framework/renderer.ts
@@ -44,7 +44,6 @@ export interface Renderer<N = HostNode, E = HostElement> {
     getElementsByTagName(element: E, tagNameOrWildCard: string): HTMLCollection;
     getElementsByClassName(element: E, names: string): HTMLCollection;
     isConnected(node: N): boolean;
-    tagName(element: E): string;
     insertGlobalStylesheet(content: string): void;
     assertInstanceOfHTMLElement?(elm: any, msg: string): void;
 }
diff --git a/packages/@lwc/engine-dom/src/renderer.ts b/packages/@lwc/engine-dom/src/renderer.ts
@@ -146,10 +146,6 @@ export const renderer: Renderer<Node, Element> = {
         return node.isConnected;
     },
 
-    tagName(element: Element): string {
-        return element.tagName;
-    },
-
     insertGlobalStylesheet(content: string): void {
         if (!isUndefined(globalStylesheets[content])) {
             return;
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-style/expected.html b/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-style/expected.html
@@ -0,0 +1,20 @@
+<x-attribute-style>
+  <template shadow-root>
+    <div style="color: red;"></div>
+    <div style="color: blue; background: black; border: 1px solid red;"></div>
+    <div
+      style="border-width: 1px; border-style: solid; border-color: red;"
+    ></div>
+    <div style="color: salmon; background-color: chocolate;"></div>
+    <x-child style="color: red;"><template shadow-root></template></x-child>
+    <x-child style="color: blue; background: black; border: 1px solid red;">
+      <template shadow-root></template>
+    </x-child>
+    <x-child style="border-width: 1px; border-style: solid; border-color: red;">
+      <template shadow-root></template>
+    </x-child>
+    <x-child style="color: salmon; background-color: chocolate;">
+      <template shadow-root></template>
+    </x-child>
+  </template>
+</x-attribute-style>
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-style/modules/x/attribute-style/attribute-style.html b/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-style/modules/x/attribute-style/attribute-style.html
@@ -0,0 +1,25 @@
+<template>
+    <!-- Standard element, simple value -->
+    <div style="color: red;"></div>
+
+    <!-- Standard element, multiple values -->
+    <div style="color: blue; background: black; border: 1px solid red;"></div>
+
+    <!-- Standard element, complex values -->
+    <div style="border-width: 1px; border-style: solid; border-color: red;"></div>
+
+    <!-- Standard element, dynamic value -->
+    <div style={dynamicStyle}></div>
+
+    <!-- Component, simple value -->
+    <x-child style="color: red;"></x-child>
+
+    <!-- Component, multiple values -->
+    <x-child style="color: blue; background: black; border: 1px solid red;"></x-child>
+
+    <!-- Component, complex values -->
+    <x-child style="border-width: 1px; border-style: solid; border-color: red;"></x-child>
+
+    <!-- Component, dynamic value -->
+    <x-child style={dynamicStyle}></x-child>
+</template>
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-style/modules/x/attribute-style/attribute-style.js b/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-style/modules/x/attribute-style/attribute-style.js
@@ -0,0 +1,5 @@
+import { LightningElement } from 'lwc';
+
+export default class StyleAttribute extends LightningElement {
+    dynamicStyle = 'color: salmon; background-color: chocolate;'
+}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-style/modules/x/child/child.js b/packages/@lwc/engine-server/src/__tests__/fixtures/attribute-style/modules/x/child/child.js
@@ -0,0 +1,3 @@
+import { LightningElement } from 'lwc';
+
+export default class Child extends LightningElement {}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/methods-noop/expected.html b/packages/@lwc/engine-server/src/__tests__/fixtures/methods-noop/expected.html
@@ -0,0 +1 @@
+<x-methods-noop><template shadow-root></template></x-methods-noop>
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/methods-noop/modules/x/methods-noop/methods-noop.js b/packages/@lwc/engine-server/src/__tests__/fixtures/methods-noop/modules/x/methods-noop/methods-noop.js
@@ -0,0 +1,8 @@
+import { LightningElement } from 'lwc';
+
+export default class MethodsNoop extends LightningElement {
+    connectedCallback() {
+        expect(() => this.addEventListener('click', () => {})).not.toThrow();
+        expect(() => this.removeEventListener('click', () => {})).not.toThrow();
+    }
+}
diff --git a/packages/@lwc/engine-server/src/renderer.ts b/packages/@lwc/engine-server/src/renderer.ts
@@ -293,10 +293,6 @@ export const renderer: Renderer<HostNode, HostElement> = {
         return true;
     },
 
-    tagName(element) {
-        return element.name;
-    },
-
     insertGlobalStylesheet() {
         // Noop on SSR (for now). This need to be reevaluated whenever we will implement support for
         // synthetic shadow.

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,6 @@ export interface Renderer<N = HostNode, E = HostElement> {`
`44`	`44`	`getElementsByTagName(element: E, tagNameOrWildCard: string): HTMLCollection;`
`45`	`45`	`getElementsByClassName(element: E, names: string): HTMLCollection;`
`46`	`46`	`isConnected(node: N): boolean;`
`47`		`- tagName(element: E): string;`
`48`	`47`	`insertGlobalStylesheet(content: string): void;`
`49`	`48`	`assertInstanceOfHTMLElement?(elm: any, msg: string): void;`
`50`	`49`	`}`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+import { LightningElement } from 'lwc';`
	`2`	`+`
	`3`	`+export default class Child extends LightningElement {}`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+<x-methods-noop><template shadow-root></template></x-methods-noop>`