✨ Add possibility to override config (tiangolo#1)

pyropy · tiangolo · web-flow · commit 6a8a9861042d · 2020-05-05T12:36:01.000+02:00
* Add possibility to override config

* ✅ Add tests for custom config

Co-authored-by: Sebastián Ramírez &lt;tiangolo@gmail.com&gt;
diff --git a/pydantic_sqlalchemy/main.py b/pydantic_sqlalchemy/main.py
@@ -9,7 +9,9 @@ class OrmConfig(BaseConfig):
     orm_mode = True
 
 
-def sqlalchemy_to_pydantic(db_model: Type) -> Type[BaseModel]:
+def sqlalchemy_to_pydantic(
+    db_model: Type, *, config: Type = OrmConfig
+) -> Type[BaseModel]:
     mapper = inspect(db_model)
     fields = {}
     for attr in mapper.attrs:
@@ -23,6 +25,6 @@ def sqlalchemy_to_pydantic(db_model: Type) -> Type[BaseModel]:
                     default = ...
                 fields[name] = (python_type, default)
     pydantic_model = create_model(
-        db_model.__name__, __config__=OrmConfig, **fields  # type: ignore
+        db_model.__name__, __config__=config, **fields  # type: ignore
     )
     return pydantic_model
diff --git a/tests/test_pydantic_sqlalchemy.py b/tests/test_pydantic_sqlalchemy.py
@@ -32,14 +32,6 @@ class Address(Base):
     user = relationship("User", back_populates="addresses")
 
 
-PydanticUser = sqlalchemy_to_pydantic(User)
-PydanticAddress = sqlalchemy_to_pydantic(Address)
-
-
-class PydanticUserWithAddresses(PydanticUser):
-    addresses: List[PydanticAddress] = []
-
-
 Base.metadata.create_all(engine)
 
 
@@ -56,7 +48,13 @@ class PydanticUserWithAddresses(PydanticUser):
 db.commit()
 
 
-def test_pydantic_sqlalchemy():
+def test_defaults() -> None:
+    PydanticUser = sqlalchemy_to_pydantic(User)
+    PydanticAddress = sqlalchemy_to_pydantic(Address)
+
+    class PydanticUserWithAddresses(PydanticUser):
+        addresses: List[PydanticAddress] = []
+
     user = db.query(User).first()
     pydantic_user = PydanticUser.from_orm(user)
     data = pydantic_user.dict()
@@ -78,3 +76,35 @@ def test_pydantic_sqlalchemy():
             {"email_address": "eddy@example.com", "id": 2, "user_id": 1},
         ],
     }
+
+
+def test_config() -> None:
+    class Config:
+        orm_mode = True
+        allow_population_by_field_name = True
+
+        @classmethod
+        def alias_generator(cls, string: str) -> str:
+            pascal_case = "".join(word.capitalize() for word in string.split("_"))
+            camel_case = pascal_case[0].lower() + pascal_case[1:]
+            return camel_case
+
+    PydanticUser = sqlalchemy_to_pydantic(User)
+    PydanticAddress = sqlalchemy_to_pydantic(Address, config=Config)
+
+    class PydanticUserWithAddresses(PydanticUser):
+        addresses: List[PydanticAddress] = []
+
+    user = db.query(User).first()
+    pydantic_user_with_addresses = PydanticUserWithAddresses.from_orm(user)
+    data = pydantic_user_with_addresses.dict(by_alias=True)
+    assert data == {
+        "fullname": "Ed Jones",
+        "id": 1,
+        "name": "ed",
+        "nickname": "edsnickname",
+        "addresses": [
+            {"emailAddress": "ed@example.com", "id": 1, "userId": 1},
+            {"emailAddress": "eddy@example.com", "id": 2, "userId": 1},
+        ],
+    }
