Fix hr not showing and improve hr spacing

tneotia · tneotia · commit ff3fdba8874d · 2021-06-28T17:38:42.000-04:00
diff --git a/lib/html_parser.dart b/lib/html_parser.dart
@@ -342,7 +342,8 @@ class HtmlParser extends StatelessWidget {
     }
 
     //Return the correct InlineSpan based on the element type.
-    if (tree.style.display == Display.BLOCK && tree.children.isNotEmpty) {
+    if (tree.style.display == Display.BLOCK &&
+        (tree.children.isNotEmpty || tree.element?.localName == "hr")) {
       if (newContext.parser.selectable) {
         return TextSpan(
           style: newContext.style.generateTextStyle(),
diff --git a/lib/src/styled_element.dart b/lib/src/styled_element.dart
@@ -248,7 +248,8 @@ StyledElement parseStyledElement(
       styledElement.style = Style(
         margin: EdgeInsets.symmetric(vertical: 7.0),
         width: double.infinity,
-        border: Border(bottom: BorderSide(width: 1.0)),
+        height: 1,
+        backgroundColor: Colors.black,
         display: Display.BLOCK,
       );
       break;

Original file line number	Diff line number	Diff line change
`@@ -342,7 +342,8 @@ class HtmlParser extends StatelessWidget {`
`342`	`342`	`}`
`343`	`343`
`344`	`344`	`//Return the correct InlineSpan based on the element type.`
`345`		`- if (tree.style.display == Display.BLOCK && tree.children.isNotEmpty) {`
	`345`	`+ if (tree.style.display == Display.BLOCK &&`
	`346`	`+ (tree.children.isNotEmpty \|\| tree.element?.localName == "hr")) {`
`346`	`347`	`if (newContext.parser.selectable) {`
`347`	`348`	`return TextSpan(`
`348`	`349`	`style: newContext.style.generateTextStyle(),`