fix(experimental-utils): fix eslint-utils' negative predicates' return types (typescript-eslint#3462)

MichaelDeBoey · web-flow · commit 1e6016b356ae · 2021-06-16T20:11:09.000-07:00
diff --git a/packages/experimental-utils/src/ast-utils/predicates.ts b/packages/experimental-utils/src/ast-utils/predicates.ts
@@ -5,7 +5,12 @@ function isOptionalChainPunctuator(
 ): token is TSESTree.PunctuatorToken & { value: '?.' } {
   return token.type === AST_TOKEN_TYPES.Punctuator && token.value === '?.';
 }
-function isNotOptionalChainPunctuator(token: TSESTree.Token): boolean {
+function isNotOptionalChainPunctuator(
+  token: TSESTree.Token,
+): token is Exclude<
+  TSESTree.Token,
+  TSESTree.PunctuatorToken & { value: '?.' }
+> {
   return !isOptionalChainPunctuator(token);
 }
 
@@ -14,7 +19,9 @@ function isNonNullAssertionPunctuator(
 ): token is TSESTree.PunctuatorToken & { value: '!' } {
   return token.type === AST_TOKEN_TYPES.Punctuator && token.value === '!';
 }
-function isNotNonNullAssertionPunctuator(token: TSESTree.Token): boolean {
+function isNotNonNullAssertionPunctuator(
+  token: TSESTree.Token,
+): token is Exclude<TSESTree.Token, TSESTree.PunctuatorToken & { value: '!' }> {
   return !isNonNullAssertionPunctuator(token);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,12 @@ function isOptionalChainPunctuator(`
`5`	`5`	`): token is TSESTree.PunctuatorToken & { value: '?.' } {`
`6`	`6`	`return token.type === AST_TOKEN_TYPES.Punctuator && token.value === '?.';`
`7`	`7`	`}`
`8`		`-function isNotOptionalChainPunctuator(token: TSESTree.Token): boolean {`
	`8`	`+function isNotOptionalChainPunctuator(`
	`9`	`+ token: TSESTree.Token,`
	`10`	`+): token is Exclude<`
	`11`	`+ TSESTree.Token,`
	`12`	`+ TSESTree.PunctuatorToken & { value: '?.' }`
	`13`	`+> {`
`9`	`14`	`return !isOptionalChainPunctuator(token);`
`10`	`15`	`}`
`11`	`16`
`@@ -14,7 +19,9 @@ function isNonNullAssertionPunctuator(`
`14`	`19`	`): token is TSESTree.PunctuatorToken & { value: '!' } {`
`15`	`20`	`return token.type === AST_TOKEN_TYPES.Punctuator && token.value === '!';`
`16`	`21`	`}`
`17`		`-function isNotNonNullAssertionPunctuator(token: TSESTree.Token): boolean {`
	`22`	`+function isNotNonNullAssertionPunctuator(`
	`23`	`+ token: TSESTree.Token,`
	`24`	`+): token is Exclude<TSESTree.Token, TSESTree.PunctuatorToken & { value: '!' }> {`
`18`	`25`	`return !isNonNullAssertionPunctuator(token);`
`19`	`26`	`}`
`20`	`27`