Update mesh_power_detective.py

ctsdownloads · web-flow · commit 0bf6020d26e9 · 2025-06-14T01:20:54.000-07:00
Multiple bug fixes to  network manager and pcie power detection.
diff --git a/MeshAnalyzer/files/mesh_power_detective.py b/MeshAnalyzer/files/mesh_power_detective.py
@@ -65,20 +65,6 @@ def check_wifi_power_save(self):
         except:
             pass
         
-        # Check iwconfig power management
-        try:
-            result = subprocess.run(f"iwconfig {self.interface}", 
-                                  shell=True, capture_output=True, text=True, timeout=5)
-            if "Power Management:on" in result.stdout:
-                issues.append({
-                    'severity': 'high',
-                    'issue': 'iwconfig shows Power Management ON',
-                    'impact': 'Causes disconnects every 1-5 minutes',
-                    'fix': f'sudo iwconfig {self.interface} power off'
-                })
-        except:
-            pass
-        
         return issues
     
     def check_usb_autosuspend(self):
@@ -150,12 +136,13 @@ def check_pcie_aspm(self):
                 if os.path.exists(aspm_path):  # FIXED: was "asmp_path"
                     with open(aspm_path, 'r') as f:  # FIXED: was "asmp_path"
                         policy = f.read().strip()
-                        if "powersave" in policy or "powersupersave" in policy:
+                        if policy[policy.find('[')+1:policy.find(']')] in ['default', 'powersave', 'powersupersave']:
                             issues.append({
                                 'severity': 'medium',
                                 'issue': f'PCIe ASPM set to: {policy}',
                                 'impact': 'Can cause latency and brief disconnects',
-                                'fix': 'Add pcie_aspm=off to kernel boot parameters'
+                                'fix': 'Add pcie_aspm=off to kernel boot parameters',
+                                'manual_only': True
                             })
         except:
             pass
@@ -168,16 +155,13 @@ def check_network_manager_power(self):
         
         try:
             # Check if NetworkManager is managing power
-            nm_conf_paths = [
-                "/etc/NetworkManager/conf.d/default-wifi-powersave-on.conf",
-                "/etc/NetworkManager/conf.d/wifi-powersave.conf"
-            ]
+            nm_conf_paths = [f for f in glob.glob("/etc/NetworkManager/conf.d/*.conf") if os.path.isfile(f)]
             
             for conf_path in nm_conf_paths:
                 if os.path.exists(conf_path):
                     with open(conf_path, 'r') as f:
                         content = f.read()
-                        if "wifi.powersave = 3" in content or "wifi.powersave = 2" in content:
+                        if "wifi.powersave = 3" in content or "wifi.powersave = 1" in content or "wifi.powersave = 0" in content:
                             issues.append({
                                 'severity': 'high',
                                 'issue': 'NetworkManager WiFi power saving enabled',
@@ -600,29 +584,21 @@ def _generate_report(self, issues):
     def _generate_fix_script(self, issues):
         """Generate a script to fix all issues"""
         fixes = []
+        manual_fixes = []
         
         for category_issues in issues.values():
             for issue in category_issues:
                 if 'fix' in issue and issue.get('severity') in ['high', 'medium']:
-                    fixes.append(issue['fix'])
-        
-        if fixes:
-            print("\n📝 Generated fix script: /tmp/fix_wifi_power.sh")
-            with open("/tmp/fix_wifi_power.sh", "w") as f:
-                f.write("#!/bin/bash\n")
-                f.write("# WiFi Power Management Fixes\n")
-                f.write("# Generated by mesh_power_detective.py\n\n")
-                
-                f.write("echo 'Applying WiFi power management fixes...'\n\n")
-                
-                for fix in fixes:
-                    f.write(f"echo 'Running: {fix}'\n")
-                    f.write(f"{fix}\n\n")
-                
-                f.write("echo 'Fixes applied! Restart WiFi or reboot to ensure all changes take effect.'\n")
-            
-            os.chmod("/tmp/fix_wifi_power.sh", 0o755)
-            print("Run with: sudo /tmp/fix_wifi_power.sh")
+                    if issue.get('manual_only', False):
+                        manual_fixes.append(issue['fix'])
+                    else:
+                        fixes.append(issue['fix'])
+        
+        if manual_fixes:
+            print("\n⚠️  Manual fixes required (cannot be automated):")
+            for fix in manual_fixes:
+                print(f"   • {fix}")
+            print("   💡 These require editing boot parameters or configuration files")
 
 
 # Usage example and testing
