fix AsyncClient::wait unexpected return after success reconnect (miguelgrinberg#1407)

arkuzo · miguelgrinberg · web-flow · commit 78d1124c50cf · 2024-12-14T00:21:21.000Z
* fix AsyncClient::wait unexpected return after success reconnect

AsyncClient::wait use sleep(1) call to wait to start reconnect task.
Sometimes reconnect is faster then 1 second, and wait returns while connection to server is established.

Added one check to avoid this situation

* Making added check easier to understand in source code

* fix Client::wait unexpected return after success reconnect

* fixes

---------

Co-authored-by: Miguel Grinberg &lt;miguel.grinberg@gmail.com&gt;
diff --git a/src/socketio/async_client.py b/src/socketio/async_client.py
@@ -189,6 +189,9 @@ async def wait(self):
             await self.eio.wait()
             await self.sleep(1)  # give the reconnect task time to start up
             if not self._reconnect_task:
+                if self.eio.state == 'connected':  # pragma: no cover
+                    # connected while sleeping above
+                    continue
                 break
             await self._reconnect_task
             if self.eio.state != 'connected':
diff --git a/src/socketio/client.py b/src/socketio/client.py
@@ -180,7 +180,12 @@ def wait(self):
             self.eio.wait()
             self.sleep(1)  # give the reconnect task time to start up
             if not self._reconnect_task:
-                break
+                if self.eio.state == 'connected':  # pragma: no cover
+                    # connected while sleeping above
+                    continue
+                else:
+                    # the reconnect task gave up
+                    break
             self._reconnect_task.join()
             if self.eio.state != 'connected':
                 break
