More logical interface for hexDataSlice (mimic slice).

ricmoo · ricmoo · commit ef5d19e5c99b · 2018-09-27T16:52:05.000-04:00
diff --git a/src.ts/utils/bytes.ts b/src.ts/utils/bytes.ts
@@ -219,7 +219,7 @@ export function hexDataLength(data: string) {
     return (data.length - 2) / 2;
 }
 
-export function hexDataSlice(data: string, offset: number, length?: number): string {
+export function hexDataSlice(data: string, offset: number, endOffset?: number): string {
     if (!isHexString(data)) {
         errors.throwError('invalid hex data', errors.INVALID_ARGUMENT, { arg: 'value', value: data });
     }
@@ -228,8 +228,8 @@ export function hexDataSlice(data: string, offset: number, length?: number): str
     }
     offset = 2 + 2 * offset;
 
-    if (length != null) {
-        return '0x' + data.substring(offset, offset + 2 * length);
+    if (endOffset != null) {
+        return '0x' + data.substring(offset, 2 + 2 * endOffset);
     }
 
     return '0x' + data.substring(offset);

Original file line number	Diff line number	Diff line change
`@@ -219,7 +219,7 @@ export function hexDataLength(data: string) {`
`219`	`219`	`return (data.length - 2) / 2;`
`220`	`220`	`}`
`221`	`221`
`222`		`-export function hexDataSlice(data: string, offset: number, length?: number): string {`
	`222`	`+export function hexDataSlice(data: string, offset: number, endOffset?: number): string {`
`223`	`223`	`if (!isHexString(data)) {`
`224`	`224`	`errors.throwError('invalid hex data', errors.INVALID_ARGUMENT, { arg: 'value', value: data });`
`225`	`225`	`}`
`@@ -228,8 +228,8 @@ export function hexDataSlice(data: string, offset: number, length?: number): str`
`228`	`228`	`}`
`229`	`229`	`offset = 2 + 2 * offset;`
`230`	`230`
`231`		`- if (length != null) {`
`232`		`- return '0x' + data.substring(offset, offset + 2 * length);`
	`231`	`+ if (endOffset != null) {`
	`232`	`+ return '0x' + data.substring(offset, 2 + 2 * endOffset);`
`233`	`233`	`}`
`234`	`234`
`235`	`235`	`return '0x' + data.substring(offset);`