list items position fixed (npm#276)

makhmudjon-inadullaev · Makhmudjon Inadullaev · web-flow · commit 16eb11917416 · 2022-10-27T19:19:10.000+05:00
* list items position fixed

* screenReader reads list item title

Co-authored-by: Makhmudjon Inadullaev &lt;makhmudjon@MakhmudjonsMBP2.home&gt;
diff --git a/theme/src/components/variant-select.js b/theme/src/components/variant-select.js
@@ -48,7 +48,7 @@ function VariantSelect(props) {
         }
       }
 
-      items.push(<Dropdown.Item onKeyDown={onItemEnterKey} onBlur={index === (variantPages.length - 1) ? collapseDropdown : undefined} tabIndex={match.variant.tabIndex} onClick={() => { window.location.href = match.page.url; }} key={match.variant.title}>{match.variant.title}</Dropdown.Item>);
+      items.push(<Dropdown.Item aria-label={`${match.variant.title}. List items ${index + 1} of ${variantPages.length}`} onKeyDown={onItemEnterKey} onBlur={index === (variantPages.length - 1) ? collapseDropdown : undefined} tabIndex={0} onClick={() => { window.location.href = match.page.url; }} key={match.variant.title}>{match.variant.title}</Dropdown.Item>);
   });
 
   return (

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ function VariantSelect(props) {`
`48`	`48`	`}`
`49`	`49`	`}`
`50`	`50`
`51`		`- items.push(<Dropdown.Item onKeyDown={onItemEnterKey} onBlur={index === (variantPages.length - 1) ? collapseDropdown : undefined} tabIndex={match.variant.tabIndex} onClick={() => { window.location.href = match.page.url; }} key={match.variant.title}>{match.variant.title}</Dropdown.Item>);`
	`51`	+ items.push(<Dropdown.Item aria-label={`${match.variant.title}. List items ${index + 1} of ${variantPages.length}`} onKeyDown={onItemEnterKey} onBlur={index === (variantPages.length - 1) ? collapseDropdown : undefined} tabIndex={0} onClick={() => { window.location.href = match.page.url; }} key={match.variant.title}>{match.variant.title}</Dropdown.Item>);
`52`	`52`	`});`
`53`	`53`
`54`	`54`	`return (`