Skip to content

llgo:pretest embed clang #234974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

llgo:pretest embed clang #234974

wants to merge 1 commit into from

Conversation

luoliwoshang
Copy link
Contributor

@luoliwoshang luoliwoshang commented Aug 26, 2025 •
edited
Loading

resolved goplus/llgo#1239

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?
❯ brew audit --strict llgo
llgo
  * line 27, col 9: https://github.com/goplus/espressif-llvm-project-prebuilt/releases/download/19.1.2_20250820/clang-esp-19.1.2_20250820-aarch64-apple-darwin.tar.xz looks like a binary package, not a source archive; homebrew/core is source-only.
  * line 31, col 9: https://github.com/goplus/espressif-llvm-project-prebuilt/releases/download/19.1.2_20250820/clang-esp-19.1.2_20250820-x86_64-apple-darwin.tar.xz looks like a binary package, not a source archive; homebrew/core is source-only.
  * line 47, col 3: `depends_on` (line 47) should be put before `resource` (line 24)
  * line 64, col 5: Use 2 (not 4) spaces for indentation.
  * line 73, col 9: Useless assignment to variable - `clang_path`.
  * line 74, col 9: Useless assignment to variable - `llvm_config_path`.
  * line 112, col 5: Use 2 (not 4) spaces for indentation.
  * line 124, col 1: Extra empty line detected at method body end.
Error: 8 problems in 1 formula detected.

@luoliwoshang luoliwoshang marked this pull request as draft August 26, 2025 09:30
@github-actions github-actions bot added the go Go use is a significant feature of the PR or issue label Aug 26, 2025
@luoliwoshang luoliwoshang mentioned this pull request Aug 27, 2025
Open
13 tasks
@stefanb stefanb added the prerelease-testing Pull request from upstream, testing a pre-release with homebrew dependencies label Aug 28, 2025
@cho-m cho-m added the audit failure CI fails while auditing the software label Sep 4, 2025
@cho-m
Copy link
Member

cho-m commented Sep 4, 2025

Going to close this PR as installing a pre-built is not allowed in Homebrew/core.

@cho-m cho-m closed this Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
audit failure CI fails while auditing the software go Go use is a significant feature of the PR or issue prerelease-testing Pull request from upstream, testing a pre-release with homebrew dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal(release): release with customize clang/llvm to brew
3 participants
@luoliwoshang @cho-m @stefanb