openai-whisper: use llvm@20 (pre-release testing)
#235317
Draft
+11
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cho-m looks like the test failure was some sort of glitch that caused a timeout? Context: Numba release manager here, I am checking on dependents and the stability of the release candidate. |
Yeah, you can ignore the failure as it is unrelated to numba/llvmlite. Likely a slow CI runner. |
b9408df to
fbeb122
Compare
daeho-ro
approved these changes
Aug 30, 2025
cho-m
commented
Aug 30, 2025
Comment on lines
+94
to
+97
|
|
||
| # TODO: remove | ||
| system libexec/"bin/python", "-m", "llvmlite.tests" | ||
| system libexec/"bin/python", "-m", "numba.runtests", "-m" |
There was a problem hiding this comment.
To remove on a future run. Just checking our shared LLVM 20 works with llvmlite via test suite:
Suggested change
| # TODO: remove | |
| system libexec/"bin/python", "-m", "llvmlite.tests" | |
| system libexec/"bin/python", "-m", "numba.runtests", "-m" |
|
FWIW: using a shared LLVM is somewhat discouraged and this setup has been removed in conda-forge: conda-forge/llvmlite-feedstock#100 -- in case you end up with user issues and weird segfaults, this may be something to consider. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing pre-releases of
llvmliteandnumbaCMake addition is for
llvmlite. Same for environment variable changes:RC tracking issues:
Tested:
system libexec/"bin/python", "-m", "llvmlite.tests"system libexec/"bin/python", "-m", "numba.runtests", "-m"