refactor(eslint-plugin): remove unnecessary type casting (typescript-eslint#246)

armano2 · bradzacher · commit b50a68bff22d · 2019-02-11T10:50:34.000-08:00
diff --git a/packages/eslint-plugin/src/rules/camelcase.ts b/packages/eslint-plugin/src/rules/camelcase.ts
@@ -19,7 +19,7 @@ export default util.createRule<Options, MessageIds>({
       category: 'Stylistic Issues',
       recommended: 'error'
     },
-    schema: baseRule.meta.schema!,
+    schema: baseRule.meta.schema,
     messages: baseRule.meta.messages
   },
   defaultOptions: [
diff --git a/packages/eslint-plugin/src/rules/indent.ts b/packages/eslint-plugin/src/rules/indent.ts
@@ -91,8 +91,8 @@ export default util.createRule<Options, MessageIds>({
       recommended: 'error'
     },
     fixable: 'whitespace',
-    schema: baseRule.meta!.schema,
-    messages: baseRule.meta!.messages
+    schema: baseRule.meta.schema,
+    messages: baseRule.meta.messages
   },
   defaultOptions: [
     // typescript docs and playground use 4 space indent
diff --git a/packages/eslint-plugin/src/rules/no-use-before-define.ts b/packages/eslint-plugin/src/rules/no-use-before-define.ts
@@ -237,7 +237,7 @@ export default util.createRule<Options, MessageIds>({
           reference.init ||
           !variable ||
           variable.identifiers.length === 0 ||
-          (variable.identifiers[0].range![1] < reference.identifier.range![1] &&
+          (variable.identifiers[0].range[1] < reference.identifier.range[1] &&
             !isInInitializer(variable, reference)) ||
           !isForbidden(variable, reference)
         ) {
diff --git a/packages/eslint-plugin/tests/rules/adjacent-overload-signatures.test.ts b/packages/eslint-plugin/tests/rules/adjacent-overload-signatures.test.ts
@@ -49,13 +49,13 @@ class Foo {}
     `
 export class Foo {}
 export class Bar {}
- export type FooBar = Foo | Bar;
+export type FooBar = Foo | Bar;
         `,
     `
 export interface Foo {}
 export class Foo {}
 export class Bar {}
- export type FooBar = Foo | Bar;
+export type FooBar = Foo | Bar;
         `,
     `
 export function foo(s: string);
diff --git a/packages/eslint-plugin/tests/rules/indent.test.ts b/packages/eslint-plugin/tests/rules/indent.test.ts
diff --git a/packages/eslint-plugin/tests/rules/member-ordering.test.ts b/packages/eslint-plugin/tests/rules/member-ordering.test.ts

Original file line number	Diff line number	Diff line change
`@@ -49,13 +49,13 @@ class Foo {}`
`49`	`49`	`
`50`	`50`	`export class Foo {}`
`51`	`51`	`export class Bar {}`
`52`		`- export type FooBar = Foo \| Bar;`
	`52`	`+export type FooBar = Foo \| Bar;`
`53`	`53`	`,
`54`	`54`	`
`55`	`55`	`export interface Foo {}`
`56`	`56`	`export class Foo {}`
`57`	`57`	`export class Bar {}`
`58`		`- export type FooBar = Foo \| Bar;`
	`58`	`+export type FooBar = Foo \| Bar;`
`59`	`59`	`,
`60`	`60`	`
`61`	`61`	`export function foo(s: string);`