Bypass unnecessary getByCode query

wtune · web-flow · commit b0bff8510c82 · 2020-01-09T20:32:05.000+08:00
For `languageService` used in https://github.com/shopizer-ecommerce/shopizer/blob/master/sm-shop/src/main/java/com/salesmanager/shop/populator/customer/CustomerPopulator.java#L232, if language code is not available(==null), it is guaranteed nothing will be retrieved since column `code` in table `LANGUAGE` is not null. In such case, the query can be bypassed and saves one network round-trip.
diff --git a/sm-shop/src/main/java/com/salesmanager/shop/populator/customer/CustomerPopulator.java b/sm-shop/src/main/java/com/salesmanager/shop/populator/customer/CustomerPopulator.java
@@ -229,7 +229,9 @@ public Customer populate(PersistableCustomer source, Customer target,
 			}
 			
 			if(target.getDefaultLanguage()==null) {
-				Language lang = languageService.getByCode(source.getLanguage());
+				Language lang = source.getLanguage() == null ?
+						null : languageService.getByCode(source.getLanguage());
+				
 				if(lang==null) {
 					lang = store.getDefaultLanguage();
 				}

Original file line number	Diff line number	Diff line change
`@@ -229,7 +229,9 @@ public Customer populate(PersistableCustomer source, Customer target,`
`229`	`229`	`}`
`230`	`230`
`231`	`231`	`if(target.getDefaultLanguage()==null) {`
`232`		`- Language lang = languageService.getByCode(source.getLanguage());`
	`232`	`+ Language lang = source.getLanguage() == null ?`
	`233`	`+ null : languageService.getByCode(source.getLanguage());`
	`234`	`+`
`233`	`235`	`if(lang==null) {`
`234`	`236`	`lang = store.getDefaultLanguage();`
`235`	`237`	`}`