fix(tls): Skip TLS SNI if host is IP address (mqttjs#1311)

A3K · web-flow · commit 2679952587a0 · 2021-12-13T07:15:24.000-08:00
This avoids showing a warning when the broker address is just an IP [DEP0123] DeprecationWarning: Setting the TLS ServerName to an IP address is not permitted by RFC 6066. This will be ignored in a future version. Same fix as node-postgres has used brianc/node-postgres@d3c8eba
diff --git a/lib/connect/tls.js b/lib/connect/tls.js
@@ -1,12 +1,16 @@
 'use strict'
 var tls = require('tls')
+var net = require('net')
 var debug = require('debug')('mqttjs:tls')
 
 function buildBuilder (mqttClient, opts) {
   var connection
   opts.port = opts.port || 8883
   opts.host = opts.hostname || opts.host || 'localhost'
-  opts.servername = opts.host
+
+  if(net.isIP(opts.host) === 0){
+    opts.servername = opts.host
+  }
 
   opts.rejectUnauthorized = opts.rejectUnauthorized !== false
 
