Skip to content

Commit c798c03

Browse files
authored
chore: Fix CI workflow for vNext-dev (mqttjs#1447)
* Chore: Fix CI workflow for vNext-dev * Use Node 16.4 for workflow jobs that need default version * update package-lock.json * Add code coverage verification * fix workflow yaml * remove typescript compatability checks
1 parent 63962da commit c798c03

File tree

4 files changed

+459
-2376
lines changed

4 files changed

+459
-2376
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
strategy:
1616
fail-fast: false
1717
matrix:
18-
node-version: [^12.22, ^14.17, ^16.4, ^17]
18+
node-version: [^14.17, ^16.4, ^17]
1919
os: [ubuntu-latest, windows-latest]
2020
steps:
2121
- uses: actions/checkout@v2
@@ -24,49 +24,24 @@ jobs:
2424
run: |
2525
git config core.symlinks true
2626
git reset --hard
27-
- run: rm .npmrc
2827
- uses: actions/setup-node@v2
2928
with:
3029
node-version: ${{ matrix.node-version }}
3130
cache: npm
3231
- name: Upgrade npm
3332
run: npm install --global npm@^8.1.2
34-
- run: npm install --no-audit
33+
- run: npm ci --no-audit
3534
- run: npm run test
3635
name: ${{ matrix.os }}/${{ matrix.node-version }}
3736

38-
typescript:
39-
name: TypeScript compatibility
40-
runs-on: ubuntu-latest
41-
strategy:
42-
matrix:
43-
ts-version: [~4.4, ~4.5]
44-
steps:
45-
- uses: actions/checkout@v2
46-
- run: rm .npmrc
47-
- uses: actions/setup-node@v2
48-
with:
49-
node-version: ^12.22
50-
cache: npm
51-
- name: Upgrade npm
52-
run: npm install --global npm@^8.1.2
53-
- run: npm install --no-audit
54-
- run: npm i typescript@${TS_VERSION}
55-
env:
56-
TS_VERSION: ${{ matrix.ts-version }}
57-
- run: npm ls typescript
58-
continue-on-error: true
59-
- run: npx tsd
60-
6137
lockfile_churn:
6238
name: Test package-lock for unexpected modifications
6339
runs-on: ubuntu-latest
6440
steps:
6541
- uses: actions/checkout@v2
66-
- run: rm .npmrc
6742
- uses: actions/setup-node@v2
6843
with:
69-
node-version: ^12.22
44+
node-version: ^16.4
7045
cache: npm
7146
- name: Upgrade npm
7247
run: if [[ "$(npm -v)" != "8.1.2" ]]; then npm install --global npm@8.1.2; fi
@@ -86,26 +61,23 @@ jobs:
8661
runs-on: ubuntu-latest
8762
steps:
8863
- uses: actions/checkout@v2
89-
- run: rm .npmrc
9064
- uses: actions/setup-node@v2
9165
with:
92-
node-version: ^12.22
66+
node-version: ^16.4
9367
- name: Upgrade npm
9468
run: npm install --global npm@^8.1.2
9569
- run: npm install --no-shrinkwrap --no-audit
96-
- run: npm run cover
9770

9871
linting:
9972
name: Lint source files
10073
runs-on: ubuntu-latest
10174
steps:
10275
- uses: actions/checkout@v2
103-
- run: rm .npmrc
10476
- uses: actions/setup-node@v2
10577
with:
10678
node-version: ^16.4
10779
cache: npm
10880
- name: Upgrade npm
10981
run: npm install --global npm@^8.1.2
110-
- run: npm install --no-audit
82+
- run: npm ci --no-audit
11183
- run: npm run lint

0 commit comments

Comments
 (0)