Replace has with get and check undefined

Benjamin Lichtman · Benjamin Lichtman · commit 34cee162ed28 · 2018-06-01T15:21:22.000-07:00
diff --git a/src/services/jsTyping.ts b/src/services/jsTyping.ts
@@ -160,7 +160,8 @@ namespace ts.JsTyping {
         }
         // Add the cached typing locations for inferred typings that are already installed
         packageNameToTypingLocation.forEach((typing, name) => {
-            if (inferredTypings.has(name) && inferredTypings.get(name) === undefined && typesRegistry.has(name) && isTypingUpToDate(typing, typesRegistry.get(name)!)) {
+            const registryEntry = typesRegistry.get(name);
+            if (inferredTypings.has(name) && inferredTypings.get(name) === undefined && registryEntry !== undefined && isTypingUpToDate(typing, typesRegistry.get(name)!)) {
                 inferredTypings.set(name, typing.typingLocation);
             }
         });

Original file line number	Diff line number	Diff line change
`@@ -160,7 +160,8 @@ namespace ts.JsTyping {`
`160`	`160`	`}`
`161`	`161`	`// Add the cached typing locations for inferred typings that are already installed`
`162`	`162`	`packageNameToTypingLocation.forEach((typing, name) => {`
`163`		`- if (inferredTypings.has(name) && inferredTypings.get(name) === undefined && typesRegistry.has(name) && isTypingUpToDate(typing, typesRegistry.get(name)!)) {`
	`163`	`+ const registryEntry = typesRegistry.get(name);`
	`164`	`+ if (inferredTypings.has(name) && inferredTypings.get(name) === undefined && registryEntry !== undefined && isTypingUpToDate(typing, typesRegistry.get(name)!)) {`
`164`	`165`	`inferredTypings.set(name, typing.typingLocation);`
`165`	`166`	`}`
`166`	`167`	`});`