Object rest skips only class methods

sandersn · sandersn · commit 945e65f4d8d7 · 2017-01-10T08:55:46.000-08:00
Previously, it skipped all methods
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -3125,9 +3125,8 @@ namespace ts {
             for (const prop of getPropertiesOfType(source)) {
                 const inNamesToRemove = prop.name in names;
                 const isPrivate = getDeclarationModifierFlagsFromSymbol(prop) & (ModifierFlags.Private | ModifierFlags.Protected);
-                const isMethod = prop.flags & SymbolFlags.Method;
                 const isSetOnlyAccessor = prop.flags & SymbolFlags.SetAccessor && !(prop.flags & SymbolFlags.GetAccessor);
-                if (!inNamesToRemove && !isPrivate && !isMethod && !isSetOnlyAccessor) {
+                if (!inNamesToRemove && !isPrivate && !isClassMethod(prop) && !isSetOnlyAccessor) {
                     members[prop.name] = prop;
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -3125,9 +3125,8 @@ namespace ts {`
`3125`	`3125`	`for (const prop of getPropertiesOfType(source)) {`
`3126`	`3126`	`const inNamesToRemove = prop.name in names;`
`3127`	`3127`	`const isPrivate = getDeclarationModifierFlagsFromSymbol(prop) & (ModifierFlags.Private \| ModifierFlags.Protected);`
`3128`		`- const isMethod = prop.flags & SymbolFlags.Method;`
`3129`	`3128`	`const isSetOnlyAccessor = prop.flags & SymbolFlags.SetAccessor && !(prop.flags & SymbolFlags.GetAccessor);`
`3130`		`- if (!inNamesToRemove && !isPrivate && !isMethod && !isSetOnlyAccessor) {`
	`3129`	`+ if (!inNamesToRemove && !isPrivate && !isClassMethod(prop) && !isSetOnlyAccessor) {`
`3131`	`3130`	`members[prop.name] = prop;`
`3132`	`3131`	`}`
`3133`	`3132`	`}`