Skip to content

Commit 7d24af1

Browse files
butlaNarretz
authored andcommitted
docs(CONTRIBUTING.md): expand test commit type, add info about closing issues
Expanded "test" to also mean test fixes. Added a link to the help page about closing issues with commit messages in the section about the footer. Closes angular#15340
1 parent ac7a2da commit 7d24af1

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

CONTRIBUTING.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ Must be one of the following:
241241
semi-colons, etc)
242242
* **refactor**: A code change that neither fixes a bug nor adds a feature
243243
* **perf**: A code change that improves performance
244-
* **test**: Adding missing tests
244+
* **test**: Adding missing or correcting existing tests
245245
* **chore**: Changes to the build process or auxiliary tools and libraries such as documentation
246246
generation
247247

@@ -264,7 +264,7 @@ The body should include the motivation for the change and contrast this with pre
264264
265265
### Footer
266266
The footer should contain any information about **Breaking Changes** and is also the place to
267-
reference GitHub issues that this commit **Closes**.
267+
[reference GitHub issues that this commit closes][closing-issues].
268268
269269
**Breaking Changes** should start with the word `BREAKING CHANGE:` with a space or two newlines. The rest of the commit message is then used for this.
270270
@@ -287,6 +287,7 @@ You can find out more detailed information about contributing in the
287287
288288
[Google Closure I18N library]: https://github.com/google/closure-library/tree/master/closure/goog/i18n
289289
[angular-dev]: https://groups.google.com/forum/?fromgroups#!forum/angular-dev
290+
[closing-issues]: https://help.github.com/articles/closing-issues-via-commit-messages/
290291
[coc]: https://github.com/angular/code-of-conduct/blob/master/CODE_OF_CONDUCT.md
291292
[commit-message-format]: https://docs.google.com/document/d/1QrDFcIiPjSLDn3EL15IJygNPiHORgU1_OOAqWjiDU5Y/edit#
292293
[contribute]: http://docs.angularjs.org/misc/contribute

0 commit comments

Comments
 (0)