test: skip 'handles Promise timeouts correctly' when ELECTRON_RUN_AS_NODE is disabled (electron#23949) (electron#24165)

miniak · codebytere · web-flow · commit 13ed82a7d5bc · 2020-06-19T11:47:01.000-05:00
Co-authored-by: Shelley Vohr &lt;shelley.vohr@gmail.com&gt;
diff --git a/spec/node-spec.js b/spec/node-spec.js
@@ -9,6 +9,7 @@ const { ipcRenderer, remote } = require('electron');
 const features = process.electronBinding('features');
 
 const { emittedOnce } = require('./events-helpers');
+const { ifit } = require('./spec-helpers');
 
 const isCI = remote.getGlobal('isCi');
 chai.use(dirtyChai);
@@ -691,7 +692,7 @@ describe('node feature', () => {
     expect(result.status).to.equal(0);
   });
 
-  it('handles Promise timeouts correctly', (done) => {
+  ifit(features.isRunAsNodeEnabled())('handles Promise timeouts correctly', (done) => {
     const scriptPath = path.join(fixtures, 'module', 'node-promise-timer.js');
     const child = ChildProcess.spawn(process.execPath, [scriptPath], {
       env: { ELECTRON_RUN_AS_NODE: 'true' }
diff --git a/spec/spec-helpers.js b/spec/spec-helpers.js
@@ -0,0 +1,2 @@
+exports.ifit = (condition) => (condition ? it : it.skip);
+exports.ifdescribe = (condition) => (condition ? describe : describe.skip);

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+exports.ifit = (condition) => (condition ? it : it.skip);`
	`2`	`+exports.ifdescribe = (condition) => (condition ? describe : describe.skip);`