Skip to content

Commit 1bde506

Browse files
fix: backport v8 patch for type inference issue (electron#22428)
* fix: backport v8 patch for type inference issue * Update .patches
1 parent 7d739a3 commit 1bde506

File tree

2 files changed

+20
-0
lines changed

2 files changed

+20
-0
lines changed

patches/v8/.patches

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,3 +8,4 @@ workaround_an_undefined_symbol_error.patch
88
do_not_export_private_v8_symbols_on_windows.patch
99
include_string_in_v8_h.patch
1010
objects_fix_memory_leak_in_prototypeusers_add.patch
11+
fix_bug_in_receiver_maps_inference.patch
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
2+
From: Samuel Attard <sattard@slack-corp.com>
3+
Date: Thu, 27 Feb 2020 11:47:31 -0800
4+
Subject: Fix bug in receiver maps inference
5+
6+
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2062404
7+
8+
diff --git a/src/compiler/node-properties.cc b/src/compiler/node-properties.cc
9+
index f43a348bb2d5b803270e42f64a3c790c52a3581b..ab4ced69ab60d6078aeb27c3d8b97e87400687ce 100644
10+
--- a/src/compiler/node-properties.cc
11+
+++ b/src/compiler/node-properties.cc
12+
@@ -386,6 +386,7 @@ NodeProperties::InferReceiverMapsResult NodeProperties::InferReceiverMapsUnsafe(
13+
// We reached the allocation of the {receiver}.
14+
return kNoReceiverMaps;
15+
}
16+
+ result = kUnreliableReceiverMaps; // JSCreate can have side-effect.
17+
break;
18+
}
19+
case IrOpcode::kJSCreatePromise: {

0 commit comments

Comments
 (0)